fix(website): storybook was hard-setting preview height - Githubissues

vmware-archive / clarity

Clarity is a scalable, accessible, customizable, open source design system built with web components. Works with any JavaScript framework, built for enterprises, and designed to be inclusive.

http://clarity.design

MIT License

6.43k stars 762 forks source link

fix(website): storybook was hard-setting preview height #6759

Closed mathisscott closed 2 years ago

mathisscott commented 2 years ago

Signed-off-by: Scott Mathis smathis@vmware.com

PR Checklist

Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] clarity.design website / infrastructure changes
[x] Other... Please describe: Dependency regression (Storybook)

What is the current behavior?

After a recent update, storybook began hardsetting demo blocks to 70px...

Screen Shot 2022-03-10 at 9 26 31 AM

Issue Number: N/A

What is the new behavior?

I unset the height...

Screen Shot 2022-03-10 at 9 38 47 AM

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information