(backport) fix(angular): set build compilation mode - Githubissues

vmware-archive / clarity

Clarity is a scalable, accessible, customizable, open source design system built with web components. Works with any JavaScript framework, built for enterprises, and designed to be inclusive.

http://clarity.design

MIT License

6.43k stars 762 forks source link

(backport) fix(angular): set build compilation mode #6763

Closed coryrylan closed 2 years ago

coryrylan commented 2 years ago

PR Checklist

Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] clarity.design website / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

cds/angular was compiling down to use the view engine output rather than use the recommended partial mode to support both view engine and ivy as described here https://angular.io/guide/angular-compiler-options#compilationmode.

Issue Number: https://github.com/vmware/clarity/issues/6745 Backport of: https://github.com/vmware/clarity/pull/6748

What is the new behavior?

cds/core now compiles the library to the correct build target.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information