search

vmware-archive / database-stream-processor

Streaming and Incremental Computation Framework
Other
225 stars 20 forks source link

Fix regression introduced in PR#305. #310

Closed ryzhyk closed 1 year ago

ryzhyk commented 1 year ago

PR #305 wraps the HTTP server in CORS middleware using most restrictive settings by default, which blocks access to HTTP endpoints from the browser connected to the same host/port. This commit changes this behavior by only enabling CORS in permissive mode when the --dev-mode flag is specified.

mihaibudiu commented 1 year ago

The code seems different from the commit message. The deleted code checks for Feb mode

github-actions[bot] commented 1 year ago

Benchmark results

Nexmark

name main [kOp/s] PR [kOp/s] Tput change [%] Assessment Peak RSS diff
q0 4007.17 3965.53 -1 :heavy_check_mark: 9.3 MB
q1 4015.87 4016.26 0 :heavy_check_mark: 2.5 MB
q2 4014.45 3930.27 -2 :heavy_check_mark: 7.9 MB
q3 4003.14 3996.2 0 :heavy_check_mark: 35.3 MB
q4 3004.26 3019.02 0 :heavy_check_mark: -15.0 MB
q5 3983.55 3982.69 0 :heavy_check_mark: -15.0 MB
q6 3239.34 3159.69 -2 :heavy_check_mark: 155.3 MB
q7 3333.53 2423.57 -27 :interrobang: 4.8 GB
q8 3872.06 3916.26 1 :heavy_check_mark: 4.8 GB
q9 596.45 606.075 2 :heavy_check_mark: 143.4 MB
q12 3762.95 3727.15 -1 :heavy_check_mark: 143.4 MB
q13 3223.86 2602.54 -19 :small_red_triangle_down: 143.4 MB
q14 4028.5 4038.63 0 :heavy_check_mark: 143.4 MB
q15 3879.01 4043.26 4 :heavy_check_mark: 143.4 MB
q16 1036.07 1037.45 0 :heavy_check_mark: 143.4 MB
q17 3082.09 3144.14 2 :heavy_check_mark: 143.4 MB
q18 857.383 892.533 4 :heavy_check_mark: 187.8 MB
q19 894.732 1036 16 :evergreen_tree: 187.8 MB
q20 1084.08 1075.89 -1 :heavy_check_mark: 187.8 MB
q21 3953.81 3961.95 0 :heavy_check_mark: 187.8 MB
q22 4022.04 4019.33 0 :heavy_check_mark: 187.8 MB

Galen

name main [s] PR [s] Runtime change [%] Assessment
galen 28.5949 28.7458 1 :heavy_check_mark:

LDBC

algorithm dataset threads main [kEVPS] PR [kEVPS] Tput change [%] Assessment Peak RSS diff
bfs graph500-22 1 1716.73 1708.99 0 :heavy_check_mark: -24.6 kB
bfs datagen-8_4-fb 6 6880.07 7605.29 11 :evergreen_tree: 93.2 MB
pagerank graph500-22 1 685.629 675.874 -1 :heavy_check_mark: 366.3 MB
pagerank datagen-8_4-fb 6 2042.49 2022.23 -1 :heavy_check_mark: -100.7 MB

Nexmark (with Persistence)

name main [kOp/s] PR [kOp/s] Tput change [%] PR DRAM [kOp/s] DRAM diff [%] Assessment
q0 2426.21 2444.26 1 2390.24 2 :heavy_check_mark:
q1 1728.16 1729.03 0 1709.32 1 :heavy_check_mark:
q2 2449.06 2439.18 0 2396.64 2 :heavy_check_mark:
q3 2084.02 2102.17 1 2271.44 -7 :heavy_check_mark:
q4 433.895 443.123 2 1407 -69 :heavy_check_mark:
q5 2085.55 2073.06 -1 2251.23 -8 :heavy_check_mark:
q6 406.146 406.687 0 1390.39 -71 :heavy_check_mark:
q7 710.042 710.854 0 1280.64 -44 :heavy_check_mark:
q8 2234.98 2200.32 -2 2218.99 -1 :heavy_check_mark:
q9 58.514 58.0424 -1 387.836 -85 :heavy_check_mark:
q12 882.456 897.316 2 1785.86 -50 :heavy_check_mark:
q13 503.204 509.894 1 1006.96 -49 :heavy_check_mark:
q14 1683.54 1716.66 2 1706.59 1 :heavy_check_mark:
q15 200.737 201.018 0 1168.3 -83 :heavy_check_mark:
q16 28.0418 28.0757 0 285.2 -90 :heavy_check_mark:
q17 90.908 90.982 0 814.692 -89 :heavy_check_mark:
q18 132.214 132.764 0 741.471 -82 :heavy_check_mark:
q19 196.474 197.001 0 649.947 -70 :heavy_check_mark:
q20 580.758 594.99 2 937.418 -37 :heavy_check_mark:
q21 1520.59 1526.49 0 1502.81 2 :heavy_check_mark:
q22 2148.24 2113.41 -2 1982.2 7 :heavy_check_mark:
codecov[bot] commented 1 year ago

Codecov Report

Merging #310 (e80bd4c) into main (ec036b5) will increase coverage by 0.00%. The diff coverage is 0.00%.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/vmware/database-stream-processor/pull/310/graphs/tree.svg?width=650&height=150&src=pr&token=0wZcmD11gt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware)](https://codecov.io/gh/vmware/database-stream-processor/pull/310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware) ```diff @@ Coverage Diff @@ ## main #310 +/- ## ======================================= Coverage 77.51% 77.51% ======================================= Files 162 162 Lines 30967 30964 -3 ======================================= - Hits 24005 24003 -2 + Misses 6962 6961 -1 ``` | [Impacted Files](https://codecov.io/gh/vmware/database-stream-processor/pull/310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware) | Coverage Δ | | |---|---|---| | [pipeline\_manager/src/main.rs](https://codecov.io/gh/vmware/database-stream-processor/pull/310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-cGlwZWxpbmVfbWFuYWdlci9zcmMvbWFpbi5ycw==) | `0.12% <0.00%> (+<0.01%)` | :arrow_up: | | [src/nexmark/generator/bids.rs](https://codecov.io/gh/vmware/database-stream-processor/pull/310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-c3JjL25leG1hcmsvZ2VuZXJhdG9yL2JpZHMucnM=) | `98.43% <0.00%> (-0.79%)` | :arrow_down: | | [src/circuit/dbsp\_handle.rs](https://codecov.io/gh/vmware/database-stream-processor/pull/310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-c3JjL2NpcmN1aXQvZGJzcF9oYW5kbGUucnM=) | `91.96% <0.00%> (-0.41%)` | :arrow_down: |