vmware-archive / database-stream-processor

Streaming and Incremental Computation Framework
Other
225 stars 20 forks source link

#321 postfix: read in batches of inputs at a time #325

Closed lalithsuresh closed 1 year ago

lalithsuresh commented 1 year ago

This method to read a batch of inputs at a time should work across various shells and be consistent between Linux and Mac OSX. I suspect it's not as fast as mapfile/readarray, but fast enough to run demo/docker_demo.sh in about 10 minutes.

codecov[bot] commented 1 year ago

Codecov Report

Merging #325 (4ba3579) into main (d8b98f4) will increase coverage by 0.01%. The diff coverage is 95.65%.

:exclamation: Current head 4ba3579 differs from pull request most recent head 20673c1. Consider uploading reports for the commit 20673c1 to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/vmware/database-stream-processor/pull/325/graphs/tree.svg?width=650&height=150&src=pr&token=0wZcmD11gt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware)](https://codecov.io/gh/vmware/database-stream-processor/pull/325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware) ```diff @@ Coverage Diff @@ ## main #325 +/- ## ========================================== + Coverage 77.81% 77.82% +0.01% ========================================== Files 166 166 Lines 32600 32618 +18 ========================================== + Hits 25367 25386 +19 + Misses 7233 7232 -1 ``` | [Impacted Files](https://codecov.io/gh/vmware/database-stream-processor/pull/325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware) | Coverage Δ | | |---|---|---| | [crates/adapters/src/server/mod.rs](https://codecov.io/gh/vmware/database-stream-processor/pull/325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-Y3JhdGVzL2FkYXB0ZXJzL3NyYy9zZXJ2ZXIvbW9kLnJz) | `44.30% <ø> (ø)` | | | [crates/pipeline\_manager/src/runner.rs](https://codecov.io/gh/vmware/database-stream-processor/pull/325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-Y3JhdGVzL3BpcGVsaW5lX21hbmFnZXIvc3JjL3J1bm5lci5ycw==) | `0.00% <0.00%> (ø)` | | | [crates/adapters/src/transport/kafka/input.rs](https://codecov.io/gh/vmware/database-stream-processor/pull/325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-Y3JhdGVzL2FkYXB0ZXJzL3NyYy90cmFuc3BvcnQva2Fma2EvaW5wdXQucnM=) | `69.69% <100.00%> (+1.22%)` | :arrow_up: | | [crates/adapters/src/transport/kafka/output.rs](https://codecov.io/gh/vmware/database-stream-processor/pull/325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-Y3JhdGVzL2FkYXB0ZXJzL3NyYy90cmFuc3BvcnQva2Fma2Evb3V0cHV0LnJz) | `62.09% <100.00%> (+2.96%)` | :arrow_up: | | [crates/dbsp/src/circuit/dbsp\_handle.rs](https://codecov.io/gh/vmware/database-stream-processor/pull/325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-Y3JhdGVzL2Ric3Avc3JjL2NpcmN1aXQvZGJzcF9oYW5kbGUucnM=) | `91.96% <0.00%> (-0.41%)` | :arrow_down: | | [crates/adapters/src/controller/stats.rs](https://codecov.io/gh/vmware/database-stream-processor/pull/325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-Y3JhdGVzL2FkYXB0ZXJzL3NyYy9jb250cm9sbGVyL3N0YXRzLnJz) | `86.68% <0.00%> (+0.27%)` | :arrow_up: | | [crates/nexmark/src/generator/bids.rs](https://codecov.io/gh/vmware/database-stream-processor/pull/325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-Y3JhdGVzL25leG1hcmsvc3JjL2dlbmVyYXRvci9iaWRzLnJz) | `99.21% <0.00%> (+0.78%)` | :arrow_up: |
ryzhyk commented 1 year ago

It works for me on Linux.