search

vmware-archive / database-stream-processor

Streaming and Incremental Computation Framework
Other
222 stars 20 forks source link

Make `Map` polymorphic #376

Closed Kixiron closed 1 year ago

Kixiron commented 1 year ago

Makes Map polymorphic over set and map inputs and outputs

codecov[bot] commented 1 year ago

Codecov Report

Merging #376 (5d5773f) into main (f463b48) will decrease coverage by 0.63%. The diff coverage is 37.90%.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/vmware/database-stream-processor/pull/376/graphs/tree.svg?width=650&height=150&src=pr&token=0wZcmD11gt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware)](https://codecov.io/gh/vmware/database-stream-processor/pull/376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware) ```diff @@ Coverage Diff @@ ## main #376 +/- ## ========================================== - Coverage 72.23% 71.61% -0.63% ========================================== Files 233 234 +1 Lines 48316 48934 +618 ========================================== + Hits 34903 35042 +139 - Misses 13413 13892 +479 ``` | [Impacted Files](https://codecov.io/gh/vmware/database-stream-processor/pull/376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware) | Coverage Δ | | |---|---|---| | [crates/dataflow-jit/src/codegen/intrinsics.rs](https://codecov.io/gh/vmware/database-stream-processor/pull/376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-Y3JhdGVzL2RhdGFmbG93LWppdC9zcmMvY29kZWdlbi9pbnRyaW5zaWNzLnJz) | `70.53% <0.00%> (-3.96%)` | :arrow_down: | | [crates/dataflow-jit/src/codegen/mod.rs](https://codecov.io/gh/vmware/database-stream-processor/pull/376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-Y3JhdGVzL2RhdGFmbG93LWppdC9zcmMvY29kZWdlbi9tb2QucnM=) | `52.75% <0.00%> (-0.41%)` | :arrow_down: | | [crates/dataflow-jit/src/dataflow/nodes.rs](https://codecov.io/gh/vmware/database-stream-processor/pull/376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-Y3JhdGVzL2RhdGFmbG93LWppdC9zcmMvZGF0YWZsb3cvbm9kZXMucnM=) | `57.14% <0.00%> (-1.69%)` | :arrow_down: | | [crates/dataflow-jit/src/facade.rs](https://codecov.io/gh/vmware/database-stream-processor/pull/376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-Y3JhdGVzL2RhdGFmbG93LWppdC9zcmMvZmFjYWRlLnJz) | `0.00% <0.00%> (ø)` | | | [crates/dataflow-jit/src/ir/exprs/select.rs](https://codecov.io/gh/vmware/database-stream-processor/pull/376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-Y3JhdGVzL2RhdGFmbG93LWppdC9zcmMvaXIvZXhwcnMvc2VsZWN0LnJz) | `61.53% <0.00%> (ø)` | | | [crates/dataflow-jit/src/ir/nodes/join.rs](https://codecov.io/gh/vmware/database-stream-processor/pull/376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-Y3JhdGVzL2RhdGFmbG93LWppdC9zcmMvaXIvbm9kZXMvam9pbi5ycw==) | `42.48% <0.00%> (ø)` | | | [crates/dataflow-jit/src/ir/nodes/subgraph.rs](https://codecov.io/gh/vmware/database-stream-processor/pull/376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-Y3JhdGVzL2RhdGFmbG93LWppdC9zcmMvaXIvbm9kZXMvc3ViZ3JhcGgucnM=) | `62.50% <0.00%> (ø)` | | | [crates/dataflow-jit/src/ir/visit.rs](https://codecov.io/gh/vmware/database-stream-processor/pull/376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-Y3JhdGVzL2RhdGFmbG93LWppdC9zcmMvaXIvdmlzaXQucnM=) | `17.54% <0.00%> (-0.43%)` | :arrow_down: | | [crates/dataflow-jit/src/lib.rs](https://codecov.io/gh/vmware/database-stream-processor/pull/376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-Y3JhdGVzL2RhdGFmbG93LWppdC9zcmMvbGliLnJz) | `100.00% <ø> (ø)` | | | [crates/dataflow-jit/src/ir/nodes/aggregate.rs](https://codecov.io/gh/vmware/database-stream-processor/pull/376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-Y3JhdGVzL2RhdGFmbG93LWppdC9zcmMvaXIvbm9kZXMvYWdncmVnYXRlLnJz) | `10.88% <0.58%> (-6.64%)` | :arrow_down: | | ... and [30 more](https://codecov.io/gh/vmware/database-stream-processor/pull/376?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware) | | ... and [2 files with indirect coverage changes](https://codecov.io/gh/vmware/database-stream-processor/pull/376/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware)
github-actions[bot] commented 1 year ago

Benchmark results

Nexmark

name main~6 [kOp/s] PR [kOp/s] Tput change [%] Assessment Peak RSS diff
q0 5357.91 5582.64 4 :heavy_check_mark: -56.9 MB
q1 5567.31 5664.62 2 :heavy_check_mark: -20.8 MB
q2 5536.42 5538.2 0 :heavy_check_mark: 14.1 MB
q3 5520.36 5642.01 2 :heavy_check_mark: -68.2 MB
q4 4913.33 4293.41 -13 :small_red_triangle_down: 28.1 MB
q5 5340.56 4366.27 -18 :small_red_triangle_down: 28.1 MB
q6 4824.6 4213.22 -13 :small_red_triangle_down: -216.8 MB
q7 3490 2648.16 -24 :small_red_triangle_down: 2.6 GB
q8 5023.55 5271.43 5 :heavy_check_mark: 2.6 GB
q9 865.627 867.109 0 :heavy_check_mark: -261.6 MB
q12 4829.01 4117.44 -15 :small_red_triangle_down: -261.6 MB
q13 3664.9 3529.24 -4 :heavy_check_mark: -261.6 MB
q14 5626.87 4902.62 -13 :small_red_triangle_down: -261.6 MB
q15 5345.81 5029.07 -6 :small_red_triangle_down: -261.6 MB
q16 1044.73 1047.55 0 :heavy_check_mark: -261.6 MB
q17 3059.13 3148.08 3 :heavy_check_mark: 57.9 MB
q18 1423.5 1416.37 -1 :heavy_check_mark: -108.6 MB
q19 1387.41 1452.64 5 :heavy_check_mark: -108.6 MB
q20 1547.04 1574.18 2 :heavy_check_mark: -108.6 MB
q21 5331.58 5009.85 -6 :small_red_triangle_down: -108.6 MB
q22 5407.58 4416.3 -18 :small_red_triangle_down: -108.6 MB

Galen

name main~6 [s] PR [s] Runtime change [%] Assessment
galen 28.6804 28.6023 0 :heavy_check_mark:

LDBC

algorithm dataset threads main~6 [kEVPS] PR [kEVPS] Tput change [%] Assessment Peak RSS diff
bfs graph500-22 1 1763.09 1754.67 0 :heavy_check_mark: 94.2 kB
bfs datagen-8_4-fb 6 7650.87 7374.63 -4 :heavy_check_mark: 52.5 MB
pagerank graph500-22 1 679.98 640.457 -6 :small_red_triangle_down: -65.5 kB
pagerank datagen-8_4-fb 6 2032.02 1930.93 -5 :heavy_check_mark: -1.3 GB

Nexmark (with Persistence)

name main~6 [kOp/s] PR [kOp/s] Tput change [%] PR DRAM [kOp/s] DRAM diff [%] Assessment
q0 2472.44 2484.48 0 2454.12 1 :heavy_check_mark:
q1 1716.38 1740.4 1 1762.47 -1 :heavy_check_mark:
q2 2429.77 2452.93 1 2456.4 0 :heavy_check_mark:
q3 2054.16 2071.98 1 2336.92 -11 :heavy_check_mark:
q4 361.191 362.73 0 1422.91 -75 :heavy_check_mark:
q5 2035.6 1979.65 -3 2383.2 -17 :heavy_check_mark:
q6 332.213 339.236 2 1352.43 -75 :heavy_check_mark:
q7 621.676 624.539 0 1306.52 -52 :heavy_check_mark:
q8 2168.78 2197.62 1 2290.92 -4 :heavy_check_mark:
q9 79.2736 80.3571 1 386.123 -79 :heavy_check_mark:
q12 863.033 864.48 0 1829.69 -53 :heavy_check_mark:
q13 410.199 439.542 7 1003.24 -56 :evergreen_tree:
q14 1725.24 1730.59 0 1725.3 0 :heavy_check_mark:
q15 197.394 197.017 0 1203.99 -84 :heavy_check_mark:
q16 25.4308 25.4691 0 285.622 -91 :heavy_check_mark:
q17 80.3398 80.7477 1 788.548 -90 :heavy_check_mark:
q18 124.953 125.121 0 797.516 -84 :heavy_check_mark:
q19 180.853 183.244 1 657.174 -72 :heavy_check_mark:
q20 516.055 526.646 2 959.869 -45 :heavy_check_mark:
q21 1511.52 1533.12 1 1524.49 1 :heavy_check_mark:
q22 2021.17 2050.29 1 2041.3 0 :heavy_check_mark: