search

vmware-archive / database-stream-processor

Streaming and Incremental Computation Framework
Other
222 stars 20 forks source link

Fix UI/manager regressions #389

Closed gz closed 1 year ago

gz commented 1 year ago
ryzhyk commented 1 year ago

There was also the issue with pipeline stats not getting displayed.

codecov[bot] commented 1 year ago

Codecov Report

Merging #389 (1ba6712) into main (34ea1f3) will decrease coverage by 0.03%. The diff coverage is 61.11%.

:exclamation: Current head 1ba6712 differs from pull request most recent head 4fb7320. Consider uploading reports for the commit 4fb7320 to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/vmware/database-stream-processor/pull/389/graphs/tree.svg?width=650&height=150&src=pr&token=0wZcmD11gt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware)](https://codecov.io/gh/vmware/database-stream-processor/pull/389?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware) ```diff @@ Coverage Diff @@ ## main #389 +/- ## ========================================== - Coverage 73.85% 73.82% -0.03% ========================================== Files 238 238 Lines 51586 51581 -5 ========================================== - Hits 38097 38081 -16 - Misses 13489 13500 +11 ``` | [Impacted Files](https://codecov.io/gh/vmware/database-stream-processor/pull/389?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware) | Coverage Δ | | |---|---|---| | [crates/dataflow-jit/src/ir/validate.rs](https://codecov.io/gh/vmware/database-stream-processor/pull/389?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-Y3JhdGVzL2RhdGFmbG93LWppdC9zcmMvaXIvdmFsaWRhdGUucnM=) | `30.01% <ø> (+0.85%)` | :arrow_up: | | [crates/pipeline\_manager/src/config.rs](https://codecov.io/gh/vmware/database-stream-processor/pull/389?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-Y3JhdGVzL3BpcGVsaW5lX21hbmFnZXIvc3JjL2NvbmZpZy5ycw==) | `0.00% <ø> (ø)` | | | [crates/pipeline\_manager/src/db/mod.rs](https://codecov.io/gh/vmware/database-stream-processor/pull/389?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-Y3JhdGVzL3BpcGVsaW5lX21hbmFnZXIvc3JjL2RiL21vZC5ycw==) | `86.34% <55.17%> (-3.00%)` | :arrow_down: | | [crates/pipeline\_manager/src/db/test.rs](https://codecov.io/gh/vmware/database-stream-processor/pull/389?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-Y3JhdGVzL3BpcGVsaW5lX21hbmFnZXIvc3JjL2RiL3Rlc3QucnM=) | `92.19% <85.71%> (-0.81%)` | :arrow_down: | ... and [2 files with indirect coverage changes](https://codecov.io/gh/vmware/database-stream-processor/pull/389/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware)
github-actions[bot] commented 1 year ago

Benchmark results

Nexmark

name main~57 [kOp/s] PR [kOp/s] Tput change [%] Assessment Peak RSS diff
q0 5262.63 5436.07 3 :heavy_check_mark: -11.3 MB
q1 5429.6 5226.95 -4 :heavy_check_mark: -4.0 MB
q2 5361.6 5437.65 1 :heavy_check_mark: -3.7 MB
q3 5321.94 5447.48 2 :heavy_check_mark: 16.1 MB
q4 4802.55 4786.13 0 :heavy_check_mark: -69.5 MB
q5 5378.33 5338.66 -1 :heavy_check_mark: -69.5 MB
q6 4880.13 4909.42 1 :heavy_check_mark: -242.4 MB
q7 2559.31 4097.32 60 :evergreen_tree: -5.8 GB
q8 5161.2 5088.91 -1 :heavy_check_mark: -5.8 GB
q9 875.448 871.473 0 :heavy_check_mark: -268.7 MB
q12 4910.28 4855.35 -1 :heavy_check_mark: -268.7 MB
q13 3645.17 3560.01 -2 :heavy_check_mark: -268.7 MB
q14 5481.43 5368.21 -2 :heavy_check_mark: -268.7 MB
q15 4895.11 5266.21 8 :evergreen_tree: -268.7 MB
q16 1045.16 1046.67 0 :heavy_check_mark: -268.7 MB
q17 3134.56 3086.27 -2 :heavy_check_mark: -75.1 MB
q18 1440.13 1439.51 0 :heavy_check_mark: 788.6 MB
q19 1435.15 1441.03 0 :heavy_check_mark: 788.6 MB
q20 1500.83 1574.52 5 :heavy_check_mark: 788.6 MB
q21 5117.36 5319.12 4 :heavy_check_mark: 788.6 MB
q22 5356.59 5421.79 1 :heavy_check_mark: 788.6 MB

Galen

name main~57 [s] PR [s] Runtime change [%] Assessment
galen 28.6952 28.966 1 :heavy_check_mark:

LDBC

algorithm dataset threads main~57 [kEVPS] PR [kEVPS] Tput change [%] Assessment Peak RSS diff
bfs graph500-22 1 1835.7 1786.87 -3 :heavy_check_mark: 20.5 kB
bfs datagen-8_4-fb 6 8173.61 7584.51 -7 :small_red_triangle_down: 28.0 MB
pagerank graph500-22 1 681.655 687.644 1 :heavy_check_mark: -69.6 kB
pagerank datagen-8_4-fb 6 1994.79 2020.01 1 :heavy_check_mark: -9.4 MB

Nexmark (with Persistence)

name main~57 [kOp/s] PR [kOp/s] Tput change [%] PR DRAM [kOp/s] DRAM diff [%] Assessment
q0 2399.23 2488.04 4 2343.28 6 :heavy_check_mark:
q1 1713.93 1707.41 0 1651.32 3 :heavy_check_mark:
q2 2407.67 2425.31 1 2351.95 3 :heavy_check_mark:
q3 2036.93 2060.41 1 2255.63 -9 :heavy_check_mark:
q4 360.256 363.319 1 1401.39 -74 :heavy_check_mark:
q5 2015.3 2053.24 2 2051.77 0 :heavy_check_mark:
q6 332.421 335.283 1 1371.28 -76 :heavy_check_mark:
q7 639.584 664.104 4 1302.55 -49 :heavy_check_mark:
q8 2171.19 2272.97 5 2224.2 2 :heavy_check_mark:
q9 79.0764 80.0189 1 379.802 -79 :heavy_check_mark:
q12 838.481 870.68 4 1785.64 -51 :heavy_check_mark:
q13 443.491 444.844 0 988.451 -55 :heavy_check_mark:
q14 1697.52 1706.38 1 1703.05 0 :heavy_check_mark:
q15 198.112 198.86 0 1189.09 -83 :heavy_check_mark:
q16 25.5771 25.7377 1 284.756 -91 :heavy_check_mark:
q17 81.4521 81.1497 0 785.149 -90 :heavy_check_mark:
q18 124.763 124.774 0 790.672 -84 :heavy_check_mark:
q19 182.489 181.242 -1 647.996 -72 :heavy_check_mark:
q20 505.761 507.754 0 932.781 -46 :heavy_check_mark:
q21 1489.8 1520.22 2 1488.73 2 :heavy_check_mark:
q22 2102.89 1959.12 -7 2052.72 -5 :small_red_triangle_down: