vmware-archive / database-stream-processor

Streaming and Incremental Computation Framework
Other
225 stars 20 forks source link

Bump `daemonize` to 0.5.0. #394

Closed ryzhyk closed 1 year ago

ryzhyk commented 1 year ago

We have two RUSTSEC alerts related to daemonize:

  1. daemonize uses boxfnonce crate, which is obsolete https://github.com/vmware/database-stream-processor/issues/328

  2. daemonize itself is unmaintained. https://github.com/vmware/database-stream-processor/issues/304

We bump daemonize to a recent 0.5 release, which resolves (1), and I guess the fact that there is a recent release indicates that it's no longer unmaintained.

lalithsuresh commented 1 year ago

@ryzhyk frankly, I don't think the daemonization adds much value. I'd drop it. If we want to run it in the background, we can just use nohup <command>.

ryzhyk commented 1 year ago

@lalithsuresh , not a fan myself, especially because it is indeed not very well maintained. But I'm not too worried because we don't use it in "real" deployment modes. For local dev use it's kind of convenient.

mihaibudiu commented 1 year ago

I thought that @blp implemented a very rich crate for this purpose.

lalithsuresh commented 1 year ago

@lalithsuresh , not a fan myself, especially because it is indeed not very well maintained. But I'm not too worried because we don't use it in "real" deployment modes. For local dev use it's kind of convenient.

Why not just use nohup during local dev in places where we use --unix-daemon today? It'll be just as convenient and has the benefit that you get the job ID right away if you want to shutdown the process later.

ryzhyk commented 1 year ago

what's the harm of keeping daemonize around for now?

codecov[bot] commented 1 year ago

Codecov Report

Merging #394 (8f85608) into main (dbe4663) will increase coverage by 1.21%. The diff coverage is 70.48%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/vmware/database-stream-processor/pull/394/graphs/tree.svg?width=650&height=150&src=pr&token=0wZcmD11gt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware)](https://app.codecov.io/gh/vmware/database-stream-processor/pull/394?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware) ```diff @@ Coverage Diff @@ ## main #394 +/- ## ========================================== + Coverage 72.99% 74.20% +1.21% ========================================== Files 237 237 Lines 49568 52300 +2732 ========================================== + Hits 36180 38811 +2631 - Misses 13388 13489 +101 ``` | [Impacted Files](https://app.codecov.io/gh/vmware/database-stream-processor/pull/394?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware) | Coverage Δ | | |---|---|---| | [crates/dataflow-jit/src/codegen/vtable/cmp.rs](https://app.codecov.io/gh/vmware/database-stream-processor/pull/394?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-Y3JhdGVzL2RhdGFmbG93LWppdC9zcmMvY29kZWdlbi92dGFibGUvY21wLnJz) | `100.00% <ø> (ø)` | | | [crates/dataflow-jit/src/codegen/vtable/debug.rs](https://app.codecov.io/gh/vmware/database-stream-processor/pull/394?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-Y3JhdGVzL2RhdGFmbG93LWppdC9zcmMvY29kZWdlbi92dGFibGUvZGVidWcucnM=) | `100.00% <ø> (ø)` | | | [crates/dataflow-jit/src/codegen/vtable/hash.rs](https://app.codecov.io/gh/vmware/database-stream-processor/pull/394?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-Y3JhdGVzL2RhdGFmbG93LWppdC9zcmMvY29kZWdlbi92dGFibGUvaGFzaC5ycw==) | `100.00% <ø> (ø)` | | | [crates/dataflow-jit/src/codegen/vtable/mod.rs](https://app.codecov.io/gh/vmware/database-stream-processor/pull/394?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-Y3JhdGVzL2RhdGFmbG93LWppdC9zcmMvY29kZWdlbi92dGFibGUvbW9kLnJz) | `92.17% <ø> (-1.45%)` | :arrow_down: | | [crates/dataflow-jit/src/facade.rs](https://app.codecov.io/gh/vmware/database-stream-processor/pull/394?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-Y3JhdGVzL2RhdGFmbG93LWppdC9zcmMvZmFjYWRlLnJz) | `86.06% <ø> (+86.06%)` | :arrow_up: | | [crates/dataflow-jit/src/ir/exprs/call.rs](https://app.codecov.io/gh/vmware/database-stream-processor/pull/394?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-Y3JhdGVzL2RhdGFmbG93LWppdC9zcmMvaXIvZXhwcnMvY2FsbC5ycw==) | `66.00% <0.00%> (-4.22%)` | :arrow_down: | | [crates/dataflow-jit/src/ir/function/passes.rs](https://app.codecov.io/gh/vmware/database-stream-processor/pull/394?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-Y3JhdGVzL2RhdGFmbG93LWppdC9zcmMvaXIvZnVuY3Rpb24vcGFzc2VzLnJz) | `55.28% <ø> (+2.70%)` | :arrow_up: | | [crates/dataflow-jit/src/ir/nodes/aggregate.rs](https://app.codecov.io/gh/vmware/database-stream-processor/pull/394?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-Y3JhdGVzL2RhdGFmbG93LWppdC9zcmMvaXIvbm9kZXMvYWdncmVnYXRlLnJz) | `10.48% <ø> (-0.40%)` | :arrow_down: | | [crates/dataflow-jit/src/ir/nodes/constant.rs](https://app.codecov.io/gh/vmware/database-stream-processor/pull/394?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-Y3JhdGVzL2RhdGFmbG93LWppdC9zcmMvaXIvbm9kZXMvY29uc3RhbnQucnM=) | `63.06% <ø> (+16.57%)` | :arrow_up: | | [crates/dataflow-jit/src/ir/nodes/differentiate.rs](https://app.codecov.io/gh/vmware/database-stream-processor/pull/394?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware#diff-Y3JhdGVzL2RhdGFmbG93LWppdC9zcmMvaXIvbm9kZXMvZGlmZmVyZW50aWF0ZS5ycw==) | `17.18% <ø> (+1.47%)` | :arrow_up: | | ... and [74 more](https://app.codecov.io/gh/vmware/database-stream-processor/pull/394?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware) | | ... and [9 files with indirect coverage changes](https://app.codecov.io/gh/vmware/database-stream-processor/pull/394/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware)