search

vmware-archive / dispatch

Dispatch is a framework for deploying and managing serverless style applications.
http://dispatchframework.io
Apache License 2.0
532 stars 58 forks source link

Support https for dispatchframework.io? #415

Open markpeek opened 6 years ago

markpeek commented 6 years ago

Does the new custom domain support for https mean we can support https for http://dispatchframework.io/ ?

kars7e commented 6 years ago

We don't use custom domains yet, it's just a redirect to vmware.github.io/dispatch. Are we ok to use custom domain?

berndtj commented 6 years ago

We're using an s3 hack to redirect "serverlessly" to pages. That's why dispatchframework.io is http-only, while the pages site is https. Not sure why we couldn't use the custom domain support.

berndtj commented 6 years ago

Ok, had to refresh my memory... since we are redirecting to a project site (i.e. https://vmware.github.io/dispatch) as opposed to a repository site (https://dispatchframework.github.io) we need the redirect.

Looks like we can add a cert though with the setup we have: https://simonecarletti.com/blog/2016/08/redirect-domain-https-amazon-cloudfront/

Or... we can move the docs to the dispatchframework repo (but I think that's a bad idea right now).

markpeek commented 6 years ago

I just thought it odd we didn't support both http and https through dispatchframework.io. Don't really care how it is implemented. But I'm fine with putting this off for now given the other tasks we have to do and enabling this in a month or two.

kars7e commented 6 years ago

I think we can support custom domain using CNAME file (https://help.github.com/articles/setting-up-an-apex-domain/). I was just concerned whether it's ok from the VMware Open Source standpoint, as no other project uses a custom domain for that.