vmware-archive / dispatch

Dispatch is a framework for deploying and managing serverless style applications.
http://dispatchframework.io
Apache License 2.0
532 stars 58 forks source link

Include seed.yaml file in the release #545

Open JeremyMarshall opened 6 years ago

JeremyMarshall commented 6 years ago

Bug Report

Expected behavior

Load examples

Current behavior

$ dispatch create --file seed.yaml --work-dir examples/
Created Function: hello-py
Created Function: http-py
Created Function: hello-js
Created Function: hello-ps1
Created Secret: open-sesame
Created API: post-hello
Created DriverType: ticker
Created Driver: ticker
[Code: 602] event-type in body is required
$ dispatch get images
  NAME | URL | BASEIMAGE | STATUS | CREATED DATE
--------------------------------------------
$ dispatch get functions
    NAME    | FUNCTIONIMAGE | STATUS |         CREATED DATE
-----------------------------------------------------------------
  hello-py  |               | ERROR  | Wed Jun 27 14:50:51 AEST 2018
  hello-ps1 |               | ERROR  | Wed Jun 27 14:50:52 AEST 2018
  http-py   |               | ERROR  | Wed Jun 27 14:50:52 AEST 2018
  hello-js  |               | ERROR  | Wed Jun 27 14:50:52 AEST 2018

Steps to reproduce

load the example seed script

Impact

Possible solution

Your Environment

$ dispatch version Client: v0.1.18 Server: v0.1.18

k8s in docker on mac 18.05.0-ce-mac67

JeremyMarshall commented 6 years ago

reverted 80d471c87c28f2eb47a5bcff5940c265976d61d9 and it fixed it. maybe its a mismatch between the download dispatch I fetched and the examples. I wasn't sure how to build from source. make make generate

kars7e commented 6 years ago

Hey @JeremyMarshall, thanks for opening the issue, it's a valid one. Seems like we need to publish the seed.yaml file and update the docs. Currently, we ask to use the seed.yaml from master branch, but master may be updated and not work anymore with the released version of dispatch (your case). I will change the title of this issue to track the progress of adding seed.yaml to the release, in the meantime, you might want to give the latest release (https://github.com/vmware/dispatch/releases/tag/v0.1.19) a try, it should include the updated API and work with latest seed file.

berndtj commented 6 years ago

Additionally, you shouldn't need the seed.yaml file to load images anymore. Simply use dispatch create seed-images

JeremyMarshall commented 6 years ago

thanks all working now. only any chance dispatch create seed-images could be idempotent? running it twice will create an error - maybe a recreate

berndtj commented 6 years ago

That's a great idea and yeah, it should be. In general, we're looking at supporting "dispatch update -i" semantics that would apply a create if the entity to be updated does not exist.