Riff functions not getting cleaned up

[berndtj]

Bug Report

I've got a rather long running deployment and only one function currently registered. However, I have a TON of function pods and deployments:

$ kubectl -n dispatch get deployments
NAME                                      DESIRED   CURRENT   UP-TO-DATE   AVAILABLE   AGE
api-gateway-kong                          1         1         1            1           14d
catalog-catalog-apiserver                 1         1         1            1           8d
catalog-catalog-controller-manager        1         1         1            1           8d
dispatch-api-manager                      1         1         1            1           14d
dispatch-application-manager              1         1         1            1           14d
dispatch-echo-server                      1         1         1            1           14d
dispatch-event-manager                    1         1         1            1           14d
dispatch-function-manager                 1         1         1            1           14d
dispatch-identity-manager                 1         1         1            1           14d
dispatch-image-manager                    1         1         1            1           14d
dispatch-secret-store                     1         1         1            1           14d
dispatch-service-manager                  1         1         1            1           14d
docker-registry-docker-registry           1         1         1            1           14d
fn-00e43143-c1dc-422d-84a0-18c144934cd9   1         1         1            1           12d
fn-1c3985ae-e82f-4b4b-8d31-e90ea5378719   1         1         1            1           12d
fn-1cc5585f-3ed9-4aa4-953c-52f79de3cf0a   1         1         1            1           12d
fn-26eac59a-7303-4885-9726-17e10e46d5f2   1         1         1            1           13d
fn-30646a3a-6944-41ab-9296-c6b86307b5ca   1         1         1            1           12d
fn-4e172db8-573c-469f-a349-81354caac54c   1         1         1            1           13d
fn-4fb9a85f-1fef-4c1f-8392-95b13b14e263   1         1         1            1           13d
fn-59185764-f79d-4fc3-b48d-7416eb64b9b8   1         1         1            1           13d
fn-596be701-c446-4b25-a6bb-f2094131eb66   1         1         1            1           13d
fn-5eb46703-134a-4978-86a9-699a4d8071a4   1         1         1            1           12d
fn-694d66b9-a9f0-452c-832f-40300c627991   0         0         0            0           6d
fn-81b8ea95-e7f0-49f5-9f00-6ce32907916c   1         1         1            1           13d
fn-82649b1a-a0bf-43ca-9fd2-f273dcbc5b99   1         1         1            1           12d
fn-885e497b-a610-4695-93ec-07986659294a   1         1         1            1           12d
fn-8c713d52-dc78-4378-86cb-3be0d55dddaf   1         1         1            1           12d
fn-9ad1b3bf-888d-4f44-af4e-17a0f3523847   1         1         1            1           13d
fn-9d1164e0-9a9a-485d-ae97-e42ee5f28456   1         1         1            1           12d
fn-9d460614-6f05-492e-b280-4917b6004604   1         1         1            1           12d
fn-d8cf71b2-b72f-445a-9ba6-9fdcecd6feb9   1         1         1            1           12d
fn-dadd2b05-5958-4d8a-871f-040066d8ea7d   1         1         1            1           13d
fn-ddbd988d-4be4-4e8d-81cd-4481b8b49217   1         1         1            1           13d
fn-e6eeed3c-a1f2-4d58-9885-cb30670f1a07   1         1         1            1           12d
fn-ebdbb22b-6631-490f-a94e-4ba2babb3ff8   1         1         1            1           12d
fn-ecfa61e6-32ca-439c-af2c-754451b140cd   1         1         1            1           12d
ingress-nginx-ingress-controller          1         1         1            1           14d
ingress-nginx-ingress-default-backend     1         1         1            1           14d
postgres-postgresql                       1         1         1            1           14d
riff-riff-function-controller             1         1         1            1           14d
riff-riff-http-gateway                    1         1         1            1           14d
riff-riff-topic-controller                1         1         1            1           14d
transport-kafka                           1         1         1            1           14d
transport-zookeeper                       1         1         1            1           14d

Expected behavior

Current behavior

Steps to reproduce

Impact

• [ ] Low - Annoyance, but does not impact business or functionality
• [x] Medium - Issue can be worked around, but is causing pain
• [ ] High - Blocker

Possible solution

Your Environment

• Dispatch CLI version (or git commit):
• Dispatch Chart version (or image[s] tag):
• Operating System and version:
• Kubernetes version (and distribution):
• Etc (any other useful environmental information):

[berndtj]

A couple additional details. The functions have been updated many times (as opposed to delete/create). Also, the functions are orphaned with regard to dispatch, but the CRDs for riff still exist and therefore I would assume that riff knows about them