search

vmware-archive / dispatch

Dispatch is a framework for deploying and managing serverless style applications.
http://dispatchframework.io
Apache License 2.0
532 stars 58 forks source link

Add create image by url #597

Closed pzmrzy closed 6 years ago

pzmrzy commented 6 years ago

Fix Issue (#594 )

berndtj commented 6 years ago

Is there an issue linked to this? Please squash commits and add helpful message.

berndtj commented 6 years ago

Also, can we add an e2e for this?

neosab commented 6 years ago

Another improvement could be the resolution of Function sourcePath which currently looks at the local filesystem. It will be nice if the CLI could try the local path else do a relative URL path while operating in this mode. I just realized the seed.yaml still won't work after this addition.

neosab commented 6 years ago

@pzmrzy Please add an E2E test for this. The test should use the seed.yaml that's part of the PR being tested by the CI job, otherwise, the yaml being tested may not be in sync with the API changes in that PR. This could lead to unnecessary CI failures.