search

vmware-archive / dispatch

Dispatch is a framework for deploying and managing serverless style applications.
http://dispatchframework.io
Apache License 2.0
532 stars 58 forks source link

Make dispatch solo compact with funky knative #635

Closed pzmrzy closed 6 years ago

tenczar commented 6 years ago

Berndt is correct that this PR does not completely handle all of the changes necessary to make Dispatch Solo work with the Knative Funky. Function creation needs to be modified to set the secrets as environment variables. These variables need to take the form of SECRETS=secret_name_1, secret_name_2, etc. Then each secret value should be another variable labeled d_secret_{secret name}, e.g d_secret_secret_name_1, d_secret_secret_name_2

berndtj commented 6 years ago

Also, this would be a GREAT opportunity to add e2e tests for solo (hopefully unmodified from the current e2e tests).

pzmrzy commented 6 years ago

Do you think we can remove all the code not related to dispatch-solo?

berndtj commented 6 years ago

I'm ok with cleaning up dead code for dispatch-solo, as long as we put it on a separate "solo" branch.