search

vmware-archive / dispatch

Dispatch is a framework for deploying and managing serverless style applications.
http://dispatchframework.io
Apache License 2.0
532 stars 58 forks source link

Add WithURL opt to driverclient #784

Closed neosab closed 5 years ago

neosab commented 5 years ago

To make our event drivers compatible with knative container source, they must be able to send events to an HTTP URL. None of the current driverclient options allow that.

kars7e commented 5 years ago

Seems like using URL works for every case, maybe we could remove others and just leave WithURL?

neosab commented 5 years ago

Seems like using URL works for every case, maybe we could remove others and just leave WithURL?

@kars7e I am fine with that. With all other options, the events endpoint path v1/events/ingest was implicitly added by the driverclient. If we are going ahead with only WithURL opt then we just need to document the endpoint for driver implementors.

kars7e commented 5 years ago

@kars7e I am fine with that. With all other options, the events endpoint path v1/events/ingest was implicitly added by the driverclient. If we are going ahead with only WithURL opt then we just need to document the endpoint for driver implementors.

Great, let's merge it as is, if we remove the current options we need to update all the drivers and that's a pain currently, let's wait with that until we have a CI/build infra for all of them in place.