search

vmware-archive / ephemerol

A Cloud Native readiness scanner
Apache License 2.0
30 stars 21 forks source link

Suggestion: Use cfenv to parse CF variables #2

Open mcowger opened 8 years ago

mcowger commented 8 years ago

https://pypi.python.org/pypi/cfenv/0.4.0

cdelashmutt-pivotal commented 8 years ago

If we were parsing out more than just the PORT environment variable I could see pulling this in. We aren't binding to services right now, but when we do start looking at more than just PORT, I think it makes sense to us cfenv for that.

Is there some other case for cfenv that I'm not considering?

mcowger commented 8 years ago

The reason I prefer cfenv is simply because it does the right thing regardless of if you are using Diego or DEA cells - so the code is a bit simpler to support both paradigms.

Its a minor suggestion I dont really have a stake in, but if you are interested in using it I'd be happy to write the patch and PR.

cdelashmutt-pivotal commented 8 years ago

Ahh, that makes sense. I don't have an env to test against DEAs any more, myself. I'm quite ok with you creating a PR for this. If you do create a PR, please include a test for this as well.

Thanks!