vmware-archive / eventrouter

A simple introspective kubernetes service that forwards events to a specified sink.
Apache License 2.0
883 stars 252 forks source link

New home for helm chart? #121

Open JoshuaC215 opened 3 years ago

JoshuaC215 commented 3 years ago

With helm stable and incubator being deprecated in a few weeks (see https://github.com/helm/charts/issues/21103), there won't be a canonical helm chart available any more for running eventrouter.

Anyone thinking about hosting one? I'm guessing it won't go here given the slow rate of updates in this repo.

We're considering it, but would be setting up the public chart repository from scratch (which appears to be pretty straightforward).

Klohto commented 3 years ago

Ping @gianrubio as well. It would be good to have this resolved before the stable deprecation timeline.

I don't think we will see much of activity here and since heptio guys don't host it from the start, I doubt they will do now.

I think Bitnami could be a good middle ground. @FraPazGal would you guys be interested in hosting eventrouter? Happy to do the PR. I believe you're parters with Heptio, but not sure if you have any internal use for eventrouter.

Klohto commented 3 years ago

Didn't realize they an official Contributing guide (apologies for pinging) but few steps need to be done before it can be placed in the catalog anyway https://github.com/bitnami/charts/blob/master/CONTRIBUTING.md#adding-a-new-chart-to-the-repository Like for example that the chart needs to use Bitnami based image.

FraPazGal commented 3 years ago

Hello @Klohto!

We would be happy to add eventrouter to our helm chart repository at bitnami/charts, thanks for thinking about us! Regarding Heptio, we are indeed both now part of VMware and, even though we may not use this chart internally right now, we would add it to our catalog gladly!

Like it says in the guide, you would need to start by creating a PR in our repo with the new chart following the structure of our charts (you can use these templates for help). You can use the current docker image to test the new chart and once the PR is created, our team will review it and work on creating the Bitnami based image that the chart will use upon release.

Following our structure for the chart creation, our Helm Chart would have the same features than the current one, but we would also add best practices and customization options as well as our common functions. Apart from that, we use a custom Bitnami based image because our pipeline maintains our images up to date, safe and functional. We perform CVE scanning, verification and functional tests and we check the upgradability of the chart before every release. For anyone interested in our release process, you can learn more at https://docs.bitnami.com/tutorials/bitnami-best-practices-hardening-charts/#bitnami-release-process-and-tests.

Klohto commented 3 years ago

Thanks a lot @FraPazGal! Since there is no word from the original Helm Chart maintianer, I will create a PR as soon as I have some spare time (or if anybody else would like to do it, feel free to do so).