search

vmware-archive / eventrouter

A simple introspective kubernetes service that forwards events to a specified sink.
Apache License 2.0
886 stars 252 forks source link

Add support for event type Info and Unknown #96

Closed richm closed 4 years ago

richm commented 5 years ago

Add support for prometheus counters for types Info and Unknown

timothysc commented 5 years ago

/assign @johnSchnake

johnSchnake commented 5 years ago

@richm Looks good as far as I can tell; do you have a way to reproduce this that I can run through?

Also, be sure to sign your commit.

richm commented 4 years ago

@richm Looks good as far as I can tell; do you have a way to reproduce this that I can run through?

The test starts here: https://github.com/openshift/origin-aggregated-logging/blob/master/test/eventrouter.sh#L129

Basically, create an event with "type": "Info", and see if the eventrouter will process it correctly (in our case, that also means passing through Fluentd and Elasticsearch, but obviously you won't need to do that for just eventrouter verification). You might also want to create an event with some other type, to see if it is correctly processed and counted by Prometheus as an "unknown" type.

Also, be sure to sign your commit.

Done.

iamsudip commented 4 years ago

Looking forward to this PR getting released soon. Thanks @richm

johnSchnake commented 4 years ago

I pushed one of the other fixes; can you rebase accordingly? The registration lines go in the NewEventRouter method now to ensure their values are ready for use.

richm commented 4 years ago

I pushed one of the other fixes; can you rebase accordingly? The registration lines go in the NewEventRouter method now to ensure their values are ready for use.

Done