vmware-archive / gangway

An application that can be used to easily enable authentication flows via OIDC for a kubernetes cluster.
Apache License 2.0
410 stars 113 forks source link

Add support for custom HTML templates #107

Closed alexbrand closed 5 years ago

alexbrand commented 5 years ago

Users who want to theme/customize gangway can provide their own set of html/template templates by way of a configmap or shared volume with a sidecar (probably better). To use custom templates, they must set the customHTMLTemplatesDir option to the path of a directory that contains the templates.

Also changed our template rendering to use html/template instead of text/template when we render the HTML.

I haven't had a chance to do a complete test because I don't have an env with an oauth provider setup. Looking to do that next.

Fixes #106

alexbrand commented 5 years ago

Good call @stevesloka. Added a notice in the documentation to let users know about this extra consideration they must make when using this feature.