vmware-archive / gangway

An application that can be used to easily enable authentication flows via OIDC for a kubernetes cluster.
Apache License 2.0
410 stars 113 forks source link

Enquote --auth-provider-arg values #116

Closed tarfu closed 5 years ago

tarfu commented 5 years ago

In a client secret for example there could be characters which won't play well with your shell like ! or | and many more. For this reason enquoting of these values is safer.

alexbrand commented 5 years ago

Thanks @tarfu. Could you please add sign-off to your commit? See https://github.com/heptiolabs/gangway/blob/master/CONTRIBUTING.md#dco-sign-off for more info on this.