search

vmware-archive / gangway

An application that can be used to easily enable authentication flows via OIDC for a kubernetes cluster.
Apache License 2.0
410 stars 113 forks source link

Fix kubeconfig --user value #129

Closed johnharris85 closed 5 years ago

johnharris85 commented 5 years ago

Recent changes to set the kubeconfig user to user@cluster aren't taking effect due to a default always being present and not triggering the logic. This removes the default and allows the proper behavior to work.

Fixes #125

Signed-off-by: John Harris joharris@vmware.com

alexbrand commented 5 years ago

Ah! Good cath @johnharris85.

LGTM but will let @stevesloka review + merge.

johnharris85 commented 5 years ago

Don't disagree, although it looks like part of the original refactoring process was to leave in some graceful deprecation logic. If we don't care about that then sure we can just kill the field, although if we want to maintain the deprecation path / warning for a version or so, this restores that.

stevesloka commented 5 years ago

@johnharris85 I think it's fine to remove. If you want to log an error if that field is set then that works so the user is aware of its deprecation.

We'll just need to make sure we have a clear release note as well.