search

vmware-archive / gangway

An application that can be used to easily enable authentication flows via OIDC for a kubernetes cluster.
Apache License 2.0
410 stars 113 forks source link

fix: Commands from commandline template fail when cluster name or credential name contain spaces #133

Closed nickperry closed 4 years ago

nickperry commented 5 years ago

Fixes https://github.com/heptiolabs/gangway/issues/131

johnharris85 commented 5 years ago

Thanks for the PR @nickperry, can you sign your commit please?

Test failure doesn't look related so hopefully it's a flake and works when kicked off again, if not we can take a look at it.

nickperry commented 5 years ago

Signed :)

nickperry commented 4 years ago

Hi @johnharris85 - can we get this merged?

danielsand commented 4 years ago

@johnharris85 hey, we really would love to see this getting merged. Any way to help and speed up the process ?

johnharris85 commented 4 years ago

ping @alexbrand / @stevesloka

danielsand commented 4 years ago

any way to speed up the merge of this fix getting to master ? @alexbrand / @stevesloka

danielsand commented 4 years ago

@stevesloka thanks for the merge - follow up question: When will be the next official release ? =]

stevesloka commented 4 years ago

Hey, @danielsand I think we'll have one soon. There are a couple other issues that we want to get fixed up. There's also a small bit of work to update the release pipeline.

zanloy commented 3 years ago

Still no new release? This fix would be great in an official release and docker image.