Improve UI and add command line instructions

vmware-archive / gangway

An application that can be used to easily enable authentication flows via OIDC for a kubernetes cluster.

Apache License 2.0

410 stars 113 forks source link

Improve UI and add command line instructions #137

Open jbrunner opened 5 years ago

jbrunner commented 5 years ago

Serve CSS/JS files localy. Resolves #136
Copy to clipboard button is placed more prominently
Places install instructions below the config instruction
Add command line instructions for users running on Windows. Resolves #102

Signed-off-by: Joshua Brunner joshua.brunner@bluewin.ch

jimangel commented 4 years ago

It would be huge for us to get Windows instructions incorporated with gangway.

Is there any help needed to move this forward / test?

/cc @alexbrand @idealhack

jenting commented 4 years ago

I tested BASH & POWERSHELL, all works as expected. And no external JS/CSS resource used.

Thanks @jbrunner

stevesloka commented 4 years ago

Thanks for this @jbrunner! I'd like to smoke test this on my cluster to see how things look.

jbrunner commented 4 years ago

@stevesloka Did you had any issues? Can i help you?

jenting commented 4 years ago

@jbrunner could you please fix the conflicting files?

I love this improvement since lots of cluster is not accessible to the outside network, so the JS/CSS resource can't be loaded. Also, it benefits the Windows users :100: .

jbrunner commented 4 years ago

@jenting now we have to wait six months again? ;)

jenting commented 4 years ago

@jenting now we have to wait six months again? ;)

ping @stevesloka, PTAL :bow:

jenting commented 4 years ago

@jbrunner If you have time, could you please take a look to make DCO happy? Thanks in advance.