search

vmware-archive / gangway

An application that can be used to easily enable authentication flows via OIDC for a kubernetes cluster.
Apache License 2.0
410 stars 112 forks source link

fix: Logout button href not using the basepath #153

Closed kdevu closed 3 years ago

kdevu commented 4 years ago

This is the fix for issue https://github.com/heptiolabs/gangway/issues/150

I've confirmed that it works for me by:

  1. Creating a docker image with the fix called MY_PRIVATE_DOCKER_REGISTRY/gangway:test
  2. Using the Gangway helm chart found here
  3. In the values.yaml file,
    • Set image.repository to MY_PRIVATE_DOCKER_REGISTRY/gangway
    • Set image.tag to test
    • Set gangway.httpPath to /gangway

e.g.

# values.yaml

    image:
      repository: MY_PRIVATE_DOCKER_REGISTRY/gangway
      tag: test

    gangway:
      httpPath: /gangway
  1. Run helm install (I'm using helm v2.15.2 and kubectl v1.16.3)
  2. Signing in to Gangway and then clicking the logout button
johnharris85 commented 4 years ago

LGTM

jenting commented 4 years ago

The CI issued got fixed, please merge the latest master branch~

kdevu commented 4 years ago

@jenting I rebased and forced pushed. The CI seems to be working now. Thank you for fixing it.

kdevu commented 4 years ago

@alexbrand / @stevesloka I was wondering if one of you two could look at this fix and merge it if there are no problems with it. Thanks in advance.