search

vmware-archive / gangway

An application that can be used to easily enable authentication flows via OIDC for a kubernetes cluster.
Apache License 2.0
409 stars 111 forks source link

Update google documentation to support offline access #97

Open Lujeni opened 5 years ago

idealhack commented 5 years ago

@Lujeni thanks for the PR ~, but I still get an empty string for refresh-token after changing the URLs. any ideas?~

EDIT: oh I forgot to kill the pod to reload config...

16Bitt commented 5 years ago

My team got a bit sidetracked today trying to get the refresh tokens to work. Any chance this PR can get merged to save other people the discovery time for adding ?access_type=offline? If needed, I'd be happy to get this branch in sync with master for the merge.

alexbrand commented 5 years ago

@16Bitt Would be great to get the branch synced up. Were you able to use these instructions successfully? Thanks!

16Bitt commented 5 years ago

@alexbrand Our team did some digging and ended up with the same exact solution. I was about to make a PR when I saw this one. I'll get this synced up today, thanks!

Lujeni commented 4 years ago

@idealhack @16Bitt @alexbrand I rebase my branch

sorry for the delay, next time feel free to ping me.

Lujeni commented 4 years ago

@idealhack friendly bump. Missing few step to integrate this MR?