search

vmware-archive / gcp-pcf-quickstart

Install Pivotal Cloud Foundry on Google Cloud Platform With One Command
Apache License 2.0
57 stars 28 forks source link

Configurable docker image #39

Closed rkoster closed 6 years ago

rkoster commented 6 years ago

This PR allows specifying docker_hub_test_repo to configure which dockerhub repo to pull the ci image from. It also converts the docker image pipeline to use the new (( )) variable syntax (for use with credential manager).

mattysweeps commented 6 years ago

@rkoster How does this effect the docker-image resource defined in the tasks? I'm assuming it overrides them. Can they be erased, or at least the reference to jrjohnsongoog/omgci removed?

rkoster commented 6 years ago

From docs:

Optional. Names an artifact source within the plan containing an image to use for the task. This overrides any image_resource configuration present in the task configuration.

This is very useful when part of your pipeline involves building an image, possibly with dependencies pre-baked. You can then propagate that image through the rest of your pipeline, guaranteeing that the correct version (and thus a consistent set of dependencies) is used throughout your pipeline.

https://concourse-ci.org/task-step.html

Also image_resource is optional according to the docs: https://concourse-ci.org/tasks.html