search

vmware-archive / git-author

An easy way to setup multiple authors based on `git commit --template`. It depends on git-together
BSD 3-Clause "New" or "Revised" License
30 stars 11 forks source link

Set up the ENV variable in the profile #1

Closed cjcjameson closed 6 years ago

cjcjameson commented 6 years ago

If someone opens up a subshell (non-login), we expect that it will inherit env variables as appropriate. So bash_profile would be better

Author: C.J. Jameson cjameson@pivotal.io

cjcjameson commented 6 years ago

@chibin @khuddlefish we'll want to encode the equivalent of this repo's setup.sh into ace-gpdbci rather than simply running this script, I think. If we just run this script, we'll get a weird diff.

xinzweb commented 6 years ago

Thanks a lot @cjcjameson.

For my own education, the .bashrc will be set for each non-login interactive session, where the .bash_profile will be executed on a login shell, which MacOS terminal will do. On most Linux environment, if I open a terminal, the .bashrc is used, however on MacOS, the .bash_profile is used.

Let me leave this setting out of the script, so people can set it properly in their own environment. Thanks. Feel free to close this PR.