search

vmware-archive / go-archive

Utilities for extracting and compressing tgz and zip files.
Apache License 2.0
0 stars 2 forks source link

Always use go tar libraries on windows #1

Closed ankeesler closed 6 years ago

ankeesler commented 6 years ago

On the latest versions of Window Server 2016 (1803) and Windows Server 2019, there is a tar executable that is shipped in the OS image. This tar executable behaves more or less the same way as the BSD tar that has been shipped with the current version of Windows stemcells, but this behavior does not function properly when Houdini streams in resources into Windows workers. We fixed the problem in concourse-windows-release by removing the system tar from the PATH: https://github.com/pivotal-cf-experimental/concourse-windows-worker-release/pull/5. We think one possible fix would be to always use the standard go library for tar operations.

pivotal-issuemaster commented 6 years ago

@ankeesler Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-issuemaster commented 6 years ago

@ankeesler Thank you for signing the Contributor License Agreement!

aminjam commented 6 years ago

@vito @jama-pivotal Is there anything we should change with this PR in order to merge it upstream? This would be helpful when we deploy concourse to Windows Server 2016 (1803) and 2019.

vito commented 6 years ago

Thanks! We were in need of this too.

https://github.com/concourse/concourse/blob/master/jobs/baggageclaim-windows/templates/start.ps1#L5

Sorry for the delay.