search

vmware-archive / go-archive

Utilities for extracting and compressing tgz and zip files.
Apache License 2.0
0 stars 2 forks source link

Build fails on FreeBSD #2

Closed mpraeger closed 5 years ago

mpraeger commented 5 years ago

Building on FreeBSD 11.2 amd64 fails:

===>  Building for concourse-fly-4.2.3
(cd /wrkdirs/usr/ports/net/concourse-fly/work;  /usr/bin/env XDG_DATA_HOME=/wrkdirs/usr/ports/net/concourse-fly/work  XDG_CONFIG_HOME=/wrkdirs/usr/ports/net/concourse-fly/work  HOME=/wrkdirs/usr/ports/net/concourse-fly/work TMPDIR="/tmp" PATH=/wrkdirs/usr/ports/net/concourse-fly/work/.bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/nonexistent/bin NO_PIE=yes MK_DEBUG_FILES=no MK_KERNEL_SYMBOLS=no SHELL=/bin/sh NO_LINT=YES PREFIX=/usr/local  LOCALBASE=/usr/local  CC="cc" CFLAGS="-O2 -pipe  -fstack-protector -fno-strict-aliasing "  CPP="cpp" CPPFLAGS=""  LDFLAGS=" -fstack-protector " LIBS=""  CXX="c++" CXXFLAGS="-O2 -pipe -fstack-protector -fno-strict-aliasing  "  MANPREFIX="/usr/local" BSD_INSTALL_PROGRAM="install  -s -m 555"  BSD_INSTALL_LIB="install  -s -m 0644"  BSD_INSTALL_SCRIPT="install  -m 555"  BSD_INSTALL_DATA="install  -m 0644"  BSD_INSTALL_MAN="install  -m 444" GOPATH="/wrkdirs/usr/ports/net/concourse-fly/work:/usr/local/share/go"  CGO_CFLAGS="-I/usr/local/include"  CGO_LDFLAGS="-L/usr/local/lib"  GOBIN="" /usr/local/bin/go  'install' -v -ldflags="-X github.com/concourse/fly/version.Version=4.2.3" github.com/concourse/fly)
github.com/onsi/gomega/types
github.com/onsi/gomega/matchers/support/goraph/node
golang.org/x/crypto/poly1305
golang.org/x/crypto/ed25519/internal/edwards25519
golang.org/x/crypto/curve25519
runtime/cgo
github.com/onsi/gomega/matchers/support/goraph/edge
github.com/onsi/gomega/internal/oraclematcher
github.com/onsi/gomega/matchers/support/goraph/util
github.com/mattn/go-isatty
github.com/vito/go-interact/interact/terminal
github.com/hashicorp/go-multierror/vendor/github.com/hashicorp/errwrap
golang.org/x/crypto/internal/chacha20
github.com/mitchellh/mapstructure
github.com/jessevdk/go-flags
github.com/mattn/go-colorable
gopkg.in/yaml.v2
github.com/cppforlife/go-semi-semantic/version
github.com/google/jsonapi
github.com/fatih/color
golang.org/x/net/context
golang.org/x/sys/unix
github.com/concourse/fly/ui
github.com/kr/pty
github.com/concourse/fly/version
github.com/pkg/term/termios
github.com/mgutz/ansi
github.com/aryann/difflib
github.com/concourse/fly/commands/internal/displayhelpers
github.com/pkg/term
github.com/cloudfoundry/bosh-cli/vendor/github.com/cloudfoundry/bosh-utils/errors
github.com/cloudfoundry/bosh-cli/vendor/github.com/bmatcuk/doublestar
github.com/cloudfoundry/bosh-cli/vendor/github.com/charlievieth/fs
github.com/cloudfoundry/bosh-cli/vendor/github.com/cloudfoundry/bosh-utils/logger
github.com/cloudfoundry/bosh-cli/vendor/gopkg.in/yaml.v2
github.com/hashicorp/go-multierror
github.com/onsi/gomega/internal/assertion
github.com/concourse/fly/template
github.com/onsi/gomega/internal/asyncassertion
github.com/onsi/gomega/internal/testingtsupport
github.com/onsi/gomega/format
github.com/cloudfoundry/bosh-cli/vendor/github.com/cloudfoundry/bosh-utils/system
github.com/onsi/gomega/matchers/support/goraph/bipartitegraph
gopkg.in/asn1-ber.v1
os/user
net
golang.org/x/crypto/ssh/terminal
github.com/onsi/gomega/gbytes
github.com/onsi/gomega/matchers
golang.org/x/crypto/ed25519
gopkg.in/square/go-jose.v2/cipher
gopkg.in/square/go-jose.v2/json
github.com/concourse/fly/pty
github.com/vito/go-interact/interact
github.com/sirupsen/logrus
code.cloudfoundry.org/lager
github.com/inconshreveable/go-update/internal/binarydist
github.com/onsi/gomega
github.com/inconshreveable/go-update/internal/osext
github.com/krishicks/yaml-patch
github.com/skratchdot/open-golang/open
github.com/mattn/go-runewidth
github.com/onsi/gomega/gexec
github.com/cloudfoundry/bosh-cli/vendor/github.com/cppforlife/go-patch/patch
gopkg.in/cheggaaa/pb.v1
github.com/cloudfoundry/bosh-cli/director/template
archive/tar
github.com/concourse/go-archive/tarfs
# github.com/concourse/go-archive/tarfs
src/github.com/concourse/go-archive/tarfs/mknod.go:23:38: cannot use int(mkdev(hdr.Devmajor, hdr.Devminor)) (type int) as type uint64 in argument to syscall.Mknod
internal/x/net/http/httpproxy
net/textproto
crypto/x509
internal/x/net/http/httpguts
github.com/inconshreveable/go-update
github.com/dgrijalva/jwt-go
gopkg.in/square/go-jose.v2
golang.org/x/crypto/ssh
crypto/tls
github.com/concourse/flag
net/http/httptrace
gopkg.in/ldap.v2
net/http
github.com/bmizerany/pat
github.com/concourse/dex/connector
golang.org/x/net/context/ctxhttp
github.com/vito/go-sse/sse
github.com/peterhellberg/link
net/http/httputil
github.com/pquerna/cachecontrol/cacheobject
github.com/gorilla/websocket
github.com/concourse/dex/connector/ldap
github.com/tedsuo/rata
github.com/concourse/atc
github.com/pquerna/cachecontrol
golang.org/x/oauth2/internal
golang.org/x/oauth2
golang.org/x/oauth2/github
github.com/concourse/dex/connector/oauth
github.com/concourse/dex/connector/gitlab
github.com/concourse/dex/connector/cf
github.com/coreos/go-oidc
github.com/concourse/dex/connector/github
github.com/concourse/atc/event
github.com/concourse/go-concourse/concourse/internal
github.com/concourse/fly/commands/internal/hijackhelpers
github.com/concourse/fly/config
github.com/concourse/dex/connector/oidc
github.com/concourse/skymarshal/skycmd
github.com/concourse/go-concourse/concourse/eventstream
github.com/concourse/fly/eventstream
github.com/concourse/go-concourse/concourse
github.com/concourse/fly/rc
github.com/concourse/fly/commands/internal/hijacker
github.com/concourse/fly/commands/internal/flaghelpers
github.com/concourse/fly/commands/internal/setpipelinehelpers
*** Error code 2

Stop.
make: stopped in /usr/ports/net/concourse-fly

Please let me know if anything is missing or you would like me to test anything.

As the go-archive repo does not have Issues enabled I am reporting it here.

vito commented 5 years ago

Not sure why go-archive had issues disabled - sorry about that! I'll transfer the issue over.

FWIW we don't currently have anyone keeping FreeBSD and other platforms working (and don't distribute binaries for it either), but I'm happy to review any PRs that fix things for those building it themselves.

mpraeger commented 5 years ago

@vito Would it be acceptable to have a solution similar to the one for mknod_windows.go? If so I can submit a PR in a bit.

vito commented 5 years ago

@mpraeger Yep! You could probably just rename that to mknod_stub.go and then add the appropriate build flag for FreeBSD up top.

mpraeger commented 5 years ago

@vito I've submitted PR #3, though DCO complains about missing signoff. Please let me know if that's something I need to add.

vito commented 5 years ago

Yep - you just need to amend with -s and force push. The bot has more details if needed.

On Mon, Mar 11, 2019, 10:14 AM Maximilian Praeger notifications@github.com wrote:

@vito https://github.com/vito I've submitted PR #3 https://github.com/concourse/go-archive/pull/3, though DCO complains about missing signoff. Please let me know if that's something I need to add.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/concourse/go-archive/issues/2#issuecomment-471555295, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAHWCXVNyJnHRMQnB89w6_gkBYLvKMMks5vVmS8gaJpZM4bnetb .

mpraeger commented 5 years ago

Thanks, done.

vito commented 5 years ago

merged #3 - thanks!

mpraeger commented 5 years ago

@vito As the main concourse repo is using tag v1.0.0 to pull in concourse/go-archive it is still using that git tag. Before opening a PR on the main repo a tag should exist for go-archive.

How would you like to proceed?

vito commented 5 years ago

@mpraeger Sorry for the delay - I've bumped the dependency upstream. :+1: