search

vmware-archive / goipmi

Go IPMI library
Apache License 2.0
191 stars 49 forks source link

Dcmi management controller string support #4

Open connorgorman opened 8 years ago

dougm commented 8 years ago

Thanks @connorgorman , looks good to me. I'd prefer to avoid using git submodules however, do you mind removing that part? Would rather vendor using a tool such as gvt, or even remove the dependency on testify and just using testing from stdlib.

dougm commented 8 years ago

We should have also seen an automated CLA request from @vmwclabot

connorgorman commented 8 years ago

@dougm Sounds good. I'll remove the dependency altogether

travisfinch commented 8 years ago

@dougm the CLA bot is not turned on for this project. I'll get it enabled today. Drop me an e-mail if there are any other projects you want it enabled on. Thanks!

vmwclabot commented 8 years ago

@connorgorman, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

connorgorman commented 8 years ago

@dougm I reverted the dependency management piece, but did leave the strechr dependency as I didn't see an easy way to decouple the project from it. Also, the CLA has been sent to Medallia's legal team. Thanks

vmwclabot commented 8 years ago

@connorgorman, your company's legal contact did not review your signed contributor license agreement within the 14 day limit. The merge can not proceed. Click here to resign the agreement.