search

vmware-archive / haret

A strongly consistent distributed coordination system, built using proven protocols & implemented in Rust.
461 stars 18 forks source link

add concrete change description #114

Closed evanmcc closed 7 years ago

evanmcc commented 7 years ago

This PR adds a section to the RFC to clarify in grinding, didactic detail all of the changes that need to be made to the protocol and state machine in order to implement the feature as described. I tried to keep it abstract and implementation neutral, but you many want to add details specific to haret since it's your RFC.

evanmcc commented 7 years ago

https://github.com/evanmcc/vrrm/pull/11 is my PR doing this work on my erlang version of VR-R.

evanmcc commented 7 years ago

sloppy of me, they aren't in vrrm either.

andrewjstone commented 7 years ago

I've had to run search/replace about fifty times in the last week for the same thing, so I understand completely.

andrewjstone commented 7 years ago

@evanmcc when you get a chance, please do the search replace so I can get this merged in. Thanks.

evanmcc commented 7 years ago

hilariously I did this about 45 seconds after you asked for it, then neglected to commit or push it :man_facepalming:

andrewjstone commented 7 years ago

Thanks!