search

vmware-archive / helm-crd

Experimental CRD controller for managing Helm releases
Apache License 2.0
100 stars 13 forks source link

fixes error message check for release not existing #15

Closed prydonius closed 6 years ago

prydonius commented 6 years ago

~~This is a quick fix for now, a better fix would be to use the ReleaseHistory GRPC method to check if the release exists or not, similar to how helm upgrade does this (https://github.com/kubernetes/helm/blob/master/cmd/helm/upgrade.go#L154)~~

@anguslees this has now been updated to use the ReleaseHistory GRPC method. I have not used the driver.ErrReleaseNotFound method that upgrade does as this pulls in unwanted kubernetes/kubernetes dependencies - so we're still stuck with checking for the "not found" substring.

prydonius commented 6 years ago

This is the relevant change in tiller 2.7.1 that broke this, btw: https://github.com/kubernetes/helm/commit/0647a7b17a76cb0c89ed6bea1c063344ced098ed