Closed sameersbn closed 6 years ago
cc @anguslees could you please take a look
I've made the suggested changes. For the tests, I've currently added tests for the resolveURL function. Will work on additional tests in a follow up PR
Thanks for the review @anguslees .. I've added support for the case where the base url ends with index.yaml
and expanded on the tests.
I've added support for the case where the base url ends with index.yaml and expanded on the tests.
IMO we shouldn't really be supporting this usecase, what's the motivation? To me, it seems like defensive programming. A repo URL with an index.yaml is not a correct repo URL:
$ helm repo add test https://bitnami.com/repo/index.yaml
Error: Looks like "https://bitnami.com/repo/index.yaml" is not a valid chart repository or cannot be reached: Failed to fetch https://bitnami.com/repo/index.yaml/index.yaml : 404 Not Found
It would be better to error out in these cases and get the user to fix the URL.
EDIT: ah I just saw @anguslees's comment about the confusion over repo URLs, sorry.
This PR enables users to specify the HTTP authorization token (in a secret) for downloading charts from a private helm repository. Following is an example manifest,
Here is a sneekpeek of the changes in action.
Fixes https://github.com/kubeapps/kubeapps/issues/269