vmware-archive / helm-crd

Experimental CRD controller for managing Helm releases
Apache License 2.0
100 stars 13 forks source link

Split chart utils in a different package. Add Gopkg files and unit tests #30

Closed andresmgot closed 6 years ago

andresmgot commented 6 years ago
andresmgot commented 6 years ago

You've combined 3 separate changes into one PR, which makes it more difficult to review

Yes, I wanted to make a separate PR for the Gopkg changes but I needed the changes for the controller unit testing. I could also have done a separate PR for the unit testing of the chart-utils pkg but since it include some small changes I wanted to ensure that the e2e functionality is not broken with the controller tests.

In any case, if you still want me to split this in three different PRs just let me know.