search

vmware-archive / http-trigger

Kubernetes CRD controller for http invocation of Kubeless functions
Apache License 2.0
9 stars 27 forks source link

Use mounted TLS certs and key #6

Closed jamding closed 5 years ago

jamding commented 5 years ago

Is this a BUG REPORT or FEATURE REQUEST?:

Feature Request

What happened:

From kubeless-cli docs its seems you can secure http-triggers using k8s's secrets. My control plane only provides an annotation for requesting signed certs and key from the CA.

What you expected to happen:

Allow configuring http-trigger resources with cert and key mounted on the resource's pod, possibly by accepting an environmental variables with the filepath to cert and key.

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment: Environment: Kubernetes version (use kubectl version): Client Version: version.Info{Major:"1", Minor:"11+", GitVersion:"v1.11.1", GitCommit:"f31005ab029ab58f05349b193fa2c22bdbe27ad3", GitTreeState:"clean", BuildDate:"2018-07-24T19:50:58Z", GoVersion:"go1.10.3", Compiler:"gc", Platform:"linux/amd64"} Server Version: version.Info{Major:"1", Minor:"11+", GitVersion:"v1.11.1-palantir1", GitCommit:"f31005ab029ab58f05349b193fa2c22bdbe27ad3", GitTreeState:"clean", BuildDate:"2018-07-24T19:46:29Z", GoVersion:"go1.10.3", Compiler:"gc", Platform:"linux/amd64"} Kubeless version (use kubeless version): Kubeless version: v1.0.0-alpha.7 Cloud provider or physical cluster: AWS

jamding commented 5 years ago

Ah I misunderstood, http-triggers are fulfilled by the ingress controller: https://github.com/kubeless/http-trigger/blob/master/pkg/utils/k8sutil.go#L292