Closed jsnowacki closed 4 years ago
What is the hold-up for this fix? I would expect most production-grade deployments to utilize multiple brokers...
@jsnowacki would you mind creating a PR with the fix?
@andresmgot I submitted a PR for the fix. I'd like to get this in ASAP, because we are in need of it for a production grade use case with 3 Kafka brokers.
It looks like the build is failing, but due to reasons not related to the changes.
Error: kafka: client has run out of available brokers to talk to (Is your cluster reachable?)
Is this a BUG REPORT or FEATURE REQUEST?: BUG REPORT
What happened: Following the external Kafka setup, if many brokers are added to
KAFKA_BROKERS
e.g.:the variable is not split into
brokersSlice
as it should but passed as-is to consumer constructor, which causes connection error, as it tries to use the whole content ofKAFKA_BROKERS
as broker address.What you expected to happen:
KAFKA_BROKERS
is split by comma and create list of brokers for consumer constructor.How to reproduce it (as minimally and precisely as possible): See above.
Anything else we need to know?: I have a fix on my fork and can submit a PR, but I am unable at the moment to run tests as the enviroment setup desctiption does not exist (https://github.com/kubeless/kafka-trigger/blob/master/docs/dev-guide.md) and manifest files in
libtest.bash
seem to be missing.Environment:
Kubernetes version (use
kubectl version
):Kubeless version (use
kubeless version
):Cloud provider or physical cluster: physical cluster