vmware-archive / kinesis-trigger

Kubernetes CRD controller for Kinesis stream as event source for Kubeless functions
Apache License 2.0
2 stars 8 forks source link

iam role credentials instead of access key/secret #5

Open toelen opened 6 years ago

toelen commented 6 years ago

FEATURE REQUEST:

Currently it is only possible to configure kinesis-trigger credentials using an aws access key and secret. However, it would be very convenient and more secure to be able to get the credentials through the normal credentials provider chain as well. Specifically when using https://github.com/jtblin/kube2iam for instance, the aws sdk should be able to get its credentials automatically

Environment:

cyrus-mc commented 6 years ago

@toelen

https://github.com/kubeless/kinesis-trigger/pull/7

Is my attempt at providing this functionality. The general logic is, if the Secret is empty the controller uses the default credentials chain (environment variables, static credentials and finally instance profile).

Creating triggers through the kubeless utility doesn't work as it expects a secret to be passed, so for write now you can only test via adding the trigger through kubectl.