vmware-archive / kube-prod-runtime

A standard infrastructure environment for Kubernetes
Apache License 2.0
764 stars 134 forks source link

node-exporter: "--path.rootfs=/rootfs" missing #1087

Open floek opened 3 years ago

floek commented 3 years ago

Hi,

I wondered, why I can't see node_filesystem_free_bytes for my xfs mounts and found, the option "--path.rootfs=/rootfs" was missing for node-exporter.

I fixed it with an override:

  nodeExporter+: {
    daemonset+: {
      spec+: {
        template+: {
          spec+:{
            containers_+: {
              default+: {
                args_+: {
                  "path.rootfs": "/rootfs",
                },
              }
            }
          }
        }
      }
    }
  },

Please change this in future releases.

Cheers, floek

javsalgar commented 3 years ago

Hi,

Thank you so much for the input! We will work on adding it. If you want to speed up the process, feel free to add a PR and we will review it