vmware-archive / kubecfg

A tool for managing complex enterprise Kubernetes environments as code.
Apache License 2.0
727 stars 62 forks source link

`vendor/github.com/genuinetools/reg` needs bump #231

Closed q3k closed 5 years ago

q3k commented 5 years ago

Over in genuintools/reg they've fixed (https://github.com/genuinetools/reg/pull/160) a bug that causes image resolving to fail when ~/.docker/config.json only contains credHelpers for a given registry host . Curiously, this is just a downstream fix from what seems like broken behaviour from calling https://github.com/docker/docker-ce/ ...

This is, for instance, triggered when trying to push to *.gcr.io with a Docker config generated by gcloud auth configure-docker, and causes failures like following when using kubecfg.resolveImage and --resolve-images registry:

WARNING unable to create registry client: Get https:///v2/: http: no Host in request URL

To fix this, vendor/github.com/genuinetools/reg needs to be updated to contain the aforementioned pull request or https://github.com/genuinetools/reg/pull/160/commits/b0626f84b3f15615022976f327677c919ed7e4a1 .