Unable to add vmware support to a cluster povisioned by kubespray

[phozzy]

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug /kind feature

What happened: After installing kubernetes cluster with kubespray I have manifests files with *.mainfest extension. That leads to https://github.com/vmware/kubernetes/blob/f50f340267a7fab8e2a959958c717868b7e4162f/enable-vcp-image/enable-vcp-scripts/daemonset_pod.sh#L186 https://github.com/vmware/kubernetes/blob/f50f340267a7fab8e2a959958c717868b7e4162f/enable-vcp-image/enable-vcp-scripts/daemonset_pod.sh#L239 checks fail. So everything breaks at this moment. What you expected to happen: I expect this scripts to be extensions agnostic. They have to check if they are yaml or json files by syntaxes check. How to reproduce it (as minimally and precisely as possible): Install cluster with kubespray, try to add vmware support.

Anything else we need to know?:

Environment:

• Kubernetes version (use kubectl version): Client Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.2", GitCommit:"81753b10df112992bf51bbc2c2f85208aad78335", GitTreeState:"clean", BuildDate:"2018-04-27T09:10:24Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}
• Cloud provider or hardware configuration: VMware
• OS (e.g. from /etc/os-release): NAME="CentOS Linux" VERSION="7 (Core)" ID="centos" ID_LIKE="rhel fedora" VERSION_ID="7" PRETTY_NAME="CentOS Linux 7 (Core)" ANSI_COLOR="0;31" CPE_NAME="cpe:/o:centos:centos:7" HOME_URL="https://www.centos.org/" BUG_REPORT_URL="https://bugs.centos.org/"

CENTOS_MANTISBT_PROJECT="CentOS-7" CENTOS_MANTISBT_PROJECT_VERSION="7" REDHAT_SUPPORT_PRODUCT="centos" REDHAT_SUPPORT_PRODUCT_VERSION="7"

• Kernel (e.g. uname -a): Linux master00 3.10.0-862.6.3.el7.x86_64 #1 SMP Tue Jun 26 16:32:21 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
• Install tools: kubespray v2.5.0
• Others:

[divyenpatel]

@phozzy kubespray support enabling vSphere Cloud Provider during deployment.

you need to edit kubespray/inventory/group_vars/all.yml and set following parameters

    $ grep -v '^#' all.yml 
bootstrap_os: ubuntu

vsphere_vcenter_ip: "10.192.44.199"
vsphere_vcenter_port: 443
vsphere_insecure: 1
vsphere_user: "Administrator@vsphere.local"
vsphere_password: "Admin!23"
vsphere_datacenter: "vcqaDC"
vsphere_datastore: "vsanDatastore"
vsphere_working_dir: "kubernetes"
vsphere_scsi_controller_type: "pvscsi"

etcd_data_dir: /var/lib/etcd

bin_dir: /usr/local/bin

This does not support multi vc/datacenter deployment, but basic single vc/datacenter setup should work fine with this.

[phozzy]

Yep, that will work. But anyway checking file-type by its extension is not good way.