search

vmware-archive / kubernetes-image-mapper

[Prototype] Apply relocation mappings on the fly to kubernetes resources
Apache License 2.0
0 stars 2 forks source link

Integration test #8

Open glyn opened 4 years ago

glyn commented 4 years ago

As pointed out in https://github.com/pivotal/kubernetes-image-mapper/pull/2/files#r348191945, controller runtime has a standard way of implementing integration tests. We should consider adding an integration test, particularly if there are scenarios which turn out to be hard to unit test.

glyn commented 4 years ago

With kube-apiserver v1.15.5 and earlier, I get an intermittent error in the integration tests:

ERROR   controller-runtime.metrics  failed to register metric   {"name": "workqueue_retries_total", "queue": "imagemap", "error": "duplicate metrics collector registration attempted"}

(full logs). This may be related to https://github.com/kubernetes/kubernetes/issues/76956, so I'm asking on kubernetes slack where to get v1.16.x of kube-apiserver to see if that helps.

glyn commented 4 years ago

Also seeing an intermittent/frequent integration test failure where an image map cannot be created because it is still being deleted. This happens even if I wait after the deletion until I can no longer get the image map. More investigation needed...