vmware-archive / lightwave

Identity services for traditional infrastructure, applications and containers.
Other
323 stars 101 forks source link

There should be more than 1 docker image #12

Open casualjim opened 7 years ago

casualjim commented 7 years ago

The docker image is treating a container as a VM. Instead there should be several containers, none of them should include systemd. A docker image should represent a single executable. Containers are like processes with resource limits attached to them.

if the process you run inside the docker container needs forking you need to make sure you run a thing as PID 1 that reaps zombies. This is an excellent example of such an init: https://github.com/Yelp/dumb-init

A docker container should also not use a SSH server you can use docker exec to enter a namespace with a shell.

For multiple docker containers to work together you can use a docker-compose file.

wfu8 commented 7 years ago

Appreciate the feedback, and points are taken as that is what container is about and how it is born. Currently lightwave container only targets to provide a way to deploy in a container-centric infrastructure without worrying about baseOS, package installation/update etc (for container users). To support 'true' container deployment, there are fundamental service refactoring work needs be done, and some of there may even involve infrastructure change, for instance, lightwave STS service currently co-located with the rest of native vmware directory service, and that needs be changed if we go after micro-services, 'real' container deployment concept etc.