search

vmware-archive / liota

Other
336 stars 120 forks source link

Response for properties and relationship calls #195

Closed KohliDev closed 6 years ago

KohliDev commented 6 years ago

Response check for relationship and properties call

KohliDev commented 6 years ago

I have updated the pull request to handle multi-threaded user packages as per @GregBollella comment above. Changes are similar to Winnie code changes in v2 features branch.

Each request(registration, properties, relationship, unregister) call will have its own unique response_queue. The dictonary of unique transaction_id and the response_queue will be maintained. The dictonary implementation in python is thred safe for single operations better to have locks which are introduced as part of this PR.

There will be thread blocking on the common respone queue part of MQTT callback. As the response is received on the basis of transaction_id they will be put into the respective queue.

KohliDev commented 6 years ago

@pmasrani @GregBollella Please review the updated PR.

KohliDev commented 6 years ago

@pmasrani I have incorporated the review comments. Hope PR can be approved for merging.

KohliDev commented 6 years ago

Thanks. Merging the PR as I have some dependent code changes to handle.