search

vmware-archive / operator-builder

A Kubebuilder plugin to accelerate the development of Kubernetes operators
MIT License
41 stars 6 forks source link

bug: replace marker with integer results in bad code #297

Open scottd018 opened 2 years ago

scottd018 commented 2 years ago

Consider the following marker:

  # +operator-builder:collection:field:name=google.projectNumber,type=int,default=12345,replace=PROJECT_NUMBER,description=`
  # +kubebuilder:validation:Required
  # Project number for the google.project that is being used.`
  member: serviceAccount:service-12345@container-engine-robot.iam.gserviceaccount.com

Results in the following error:

/home/scottd018/VSCode/github/project/operator/bin/controller-gen "crd:preserveUnknownFields=false,crdVersions=v1,trivialVersions=true" rbac:roleName=manager-role webhook paths="./..." output:crd:artifacts:config=config/crd/bases
/home/scottd018/VSCode/github/project/operator/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
go fmt ./...
go vet ./...
# github.com/project/operator/apis/infra/v1alpha1/cluster
apis/infra/v1alpha1/cluster/google_kms_key.go:141:41: invalid operation: "serviceAccount:service-" + collection.Spec.Google.ProjectNumber (mismatched types untyped string and int)
make: *** [Makefile:50: vet] Error 2