vmware-archive / ovsdb-client-library

An OVSDB client for interacting with an OVSDB server.
Other
12 stars 6 forks source link

Make startListeningOnPort() asynchronous #1

Closed hechaoli closed 6 years ago

hechaoli commented 6 years ago

Call addListener on server channel's close future instead of blocking on it.

vmwclabot commented 6 years ago

@hechaoli, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 5


Changes Missing Coverage Covered Lines Changed/Added Lines %
ovsdb-client/src/main/java/com/vmware/ovsdb/service/impl/OvsdbPassiveConnectionListenerImpl.java 6 7 85.71%
<!-- Total: 6 7 85.71% -->
Files with Coverage Reduction New Missed Lines %
ovsdb-client/src/main/java/com/vmware/ovsdb/netty/OvsdbClientHandler.java 2 69.47%
ovsdb-client/src/main/java/com/vmware/ovsdb/service/impl/OvsdbPassiveConnectionListenerImpl.java 2 81.82%
<!-- Total: 4 -->
Totals Coverage Status
Change from base Build 3: -0.2%
Covered Lines: 1291
Relevant Lines: 1776

💛 - Coveralls