vmware-archive / pcf-pipelines

PCF Pipelines
Apache License 2.0
158 stars 282 forks source link

upgrade-ops-manager only checks for running/pending changes before exporting settings but not after #205

Closed eamonryan closed 6 years ago

eamonryan commented 7 years ago

The current initial task order for upgrade-ops-manager is:

  - task: wait-opsman-clear
  - task: export-opsmgr-settings
  - task: exported-opsmgr-diagnostic-report
  - task: deploy-opsman-vm

However, the export-opsmgr-settings task can take upwards of 10 minutes to complete, given that it is generating a rather large file.

It is possible for some user (or pipeline) to add in a pending change or begin an apply-changes operation during this long time window.

Can we account for this by adding a new check after the settings have been exported that fails the pipeline if new changes are detected or runs a new wait-opsman-clear and then re-exports the settings before continuing?

cf-gitbot commented 7 years ago

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

abbyachau commented 6 years ago

Hi @eamonryan, we just published v22 which contains this enhancement. Please do not hesitate to reach out if you have any feedback. Thanks again.