create-offline-pinned-pipelines fails due to mixed api token requirements

[punkadiddle]

Issue

Running create-offline-pinned-pipelines the task create-tarball within create-elastic-runtime-tarball contains a script that uses pivnet-cli which requires a legacy API token. Some of the other tasks seems to require new-style tokens and do not work with legacy.

Context

Broken product requires additional time and qualification to fix.

Expected result

Smooth download.

Current result

create-offline-pinned-pipelines defect

Steps to Reproduce

Run create-offline-pinned-pipelines

Possible Fix

Provide both old an new style API tokens (patch below). Fix pivnet cli.

yaml_patch

- op: replace
  path: /jobs/name=create-elastic-runtime-tarball/plan/task=create-tarball/config/params/PIVNET_API_TOKEN
  value: {{pivnet_legacy_token}}

Logs and Screenshots

create-elastic-runtime-tarball / create-tarball output

Downloading stemcell 3468.21
+ pivnet-cli login --api-token=<replaced my new-style token>
Failed to login

[cf-gitbot]

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

[abbyachau]

@punkadiddle thanks for creating this issue. Can you tell us 1) are you using the PivNet version of pcf-pipelines 2) which version of the pipelines you are on. Thanks.

[punkadiddle]

Using v0.23.1-rc.15. pivnet-cli is used within the pipeline, not downloaded separately. It's probably part of czero/rootfs.

[abbyachau]

Thanks @punkadiddle I was actually asking whether you are using the Pivotal Network version of the pipelines release?

[punkadiddle]

No. I was using a clone of this repository with tag v0.23.1-rc.15

[abbyachau]

Sorry about the delay - @punkadiddle which tasks are failing? I spoke to the Pivotal Network team and they have not yet deprecated the legacy tokens. Thanks.

[abbyachau]

Hi @punkadiddle please let us know if this is still an issue. We encourage folks not to use a rc as these release candidates are unstable. Please use the PivNet release or a tagged official release of the product for stability. Please also review this issue as this might be a contributing factor to the errors you've noticed. Thanks.

[punkadiddle]

v0.23.1-rc.36 works using only the legacy api token.