search

vmware-archive / pcf-pipelines

PCF Pipelines
Apache License 2.0
158 stars 284 forks source link

Allow flexible and custom networking configuration for vSphere #295

Open rmeharg opened 6 years ago

rmeharg commented 6 years ago

Issue

Pipeline configuration does not allow network configuration for vSphere to meet enterprise requirements at the infrastructure layer.

Release: v22 Pipeline: install-pcf IaaS: vsphere Version: 1.12.x

Context

I am currently working with a customer which has a complex vSphere network setup. Each foundation has 3 networks for deployment and 3 networks for services (one per AZ) and currently no dynamic services network.

The current pcf-pipelines only supports configuration of three specific networks and are required. Unfortunately the customer has 9 large PCF foundations and cannot easily change the network structure.

Possible Fix

I am having to make some customisations around supporting an array of networks and also no dynamic services network if left blank.

I would like to PR these customisations so I would like opinions on the best way to approach this to minimise rework.

Would it be best to replace the current network configuration options entirely or to provide an option/flag to provide custom networks? I am also aware there may be some limitations on using yaml arrays or json configuration with Concourse pipelines.

cf-gitbot commented 6 years ago

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

abbyachau commented 6 years ago

Hi @RMeharg. Thanks for creating this issue. Are you able to use yaml-patch for any of the customizations? If so, providing an ops file would be ideal.

rmeharg commented 6 years ago

I could for the pipeline.yml, however there would also have to be fundamental changes to the task.sh.

I don't think operation specific logic should be part of task.sh but if this is the recommended approach then we will do it that way.

I would like this to eventually be part of the core pcf-pipelines as it will be more inline with the network configuration in the Ops Manager UI.

abbyachau commented 6 years ago

@RMeharg let's arrange to speak when you have time. It's not clear to me what changes you are proposing. Thanks.

bmhkb4 commented 6 years ago

+1 on this, we are trying to add isolation segment(s) and you have to update the director network config before adding it.