Allow additional and custom network configuration for vSphere

[rmeharg]

Thanks for contributing to pcf-pipelines. To speed up the process of reviewing your pull request please provide us with:

• A short explanation of the proposed change: Adds ability to configure ops director with additional and custom network topologies and exclude default network configuration.

• An explanation of the use cases your change solves: A user had PCF deployed with a custom network topology. This allows them to configure PCF to support their infrastructure setup.

• Expected result after the change: Additional networks and subnets can be specified using a json string. Default networks can be left blank and are excluded from the director configuration.

• Current result before the change: No additional networks or subnets could be added. Leaving default network configuration blank caused pipeline errors. Users may not have separate infrastructure or service networks and therefore pipelines fail.

• Links to any other associated PRs or issues: Fixes issue #295

Tested and developed to ensure backwards compatibility and no breaking changes.

Tested with default and custom, default only and custom only network configurations

• [x] I have viewed signed and have submitted the Contributor License Agreement

• [x] I have made this pull request to the master branch

• [x] I have run all the unit tests

[cf-gitbot]

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

[abbyachau]

Hi @RMeharg thanks again for speaking today. As discussed, we won't be pulling in this pull request as our pipelines still adheres to c0's reference architecture. I'll leave this pull request open for folks to comment and for those interested in a more configurable approach to networking. Thanks again for contributing this though.

[rmeharg]

I have discussed this with the customer and we will see how difficult it is to migrate to the recommended reference architecture and fit it into the roadmap, thanks for the quick response and the call today.

Also as mentioned by someone in issue #295, this could also be used for adding multiple isolation segments, a use case which I didn't even consider.

[calebwashburn]

Thanks for input, closing but will ensure we have item in backlog to allow more configurable approach to your iaas networking needs.