search

vmware-archive / pcf-pipelines

PCF Pipelines
Apache License 2.0
158 stars 282 forks source link

Refactor aws terraform #301

Closed gopisaba closed 6 years ago

gopisaba commented 6 years ago

Thanks for contributing to pcf-pipelines. To speed up the process of reviewing your pull request please provide us with:

Plan: 90 to add, 0 to change, 0 to destroy.

* Current result before the change:
  - Terraform Plan

<= data.aws_iam_policy_document.pcf_iam_rds_role_policy_document id: json: policy_id: "pcf-nonprod_IamRdsRolePolicyDocument" statement.#: "6" statement.0.actions.#: "41" statement.0.actions.1037937706: "iam:GetAccountAuthorizationDetails" statement.0.actions.128555758: "iam:SetDefaultPolicyVersion" statement.0.actions.1312114282: "iam:GetCredentialReport" statement.0.actions.13746420: "iam:RemoveRoleFromInstanceProfile" statement.0.actions.1380368002: "iam:GetSAMLProvider" statement.0.actions.1674429599: "iam:GetRole" statement.0.actions.1925855670: "iam:Update" statement.0.actions.2497561494: "iam:Create" statement.0.actions.2522401458: "iam:SimulatePrincipalPolicy" statement.0.actions.2726323048: "iam:GetServiceLastAccessedDetails" statement.0.actions.2757730094: "iam:GetContextKeysForCustomPolicy" statement.0.actions.2797148376: "iam:SimulateCustomPolicy" statement.0.actions.2892165247: "iam:Put" statement.0.actions.2907882226: "iam:GenerateServiceLastAccessedDetails" statement.0.actions.304513894: "iam:GetAccountSummary" statement.0.actions.3098860698: "iam:Attach" statement.0.actions.3126187117: "iam:GetOpenIDConnectProvider" statement.0.actions.3245363121: "iam:GetUser" statement.0.actions.3282607001: "iam:GetAccountPasswordPolicy" statement.0.actions.3405168396: "iam:ChangePassword" statement.0.actions.3462103588: "iam:GetPolicyVersion" statement.0.actions.3508470034: "iam:GetServerCertificate" statement.0.actions.3585023987: "iam:GetGroup" statement.0.actions.3623887571: "iam:GetSSHPublicKey" statement.0.actions.3638137184: "iam:RemoveClientIDFromOpenIDConnectProvider" statement.0.actions.3661080708: "iam:List" statement.0.actions.3675855692: "iam:GetPolicy" statement.0.actions.3762934075: "iam:GetRolePolicy" statement.0.actions.3777628553: "iam:GetAccessKeyLastUsed" statement.0.actions.3948664466: "iam:EnableMFADevice" statement.0.actions.4008615879: "iam:Delete" statement.0.actions.4168022639: "iam:GetLoginProfile" statement.0.actions.4276945891: "iam:ResyncMFADevice" statement.0.actions.4286421756: "iam:DeactivateMFADevice" statement.0.actions.448433171: "iam:GetContextKeysForPrincipalPolicy" statement.0.actions.739661930: "iam:GenerateCredentialReport" statement.0.actions.762776940: "iam:RemoveUserFromGroup" statement.0.actions.775760823: "iam:GetUserPolicy" statement.0.actions.833023352: "iam:GetGroupPolicy" statement.0.actions.838681988: "iam:Detach" statement.0.actions.90299847: "iam:Add" statement.0.effect: "Deny" statement.0.resources.#: "1" statement.0.resources.2679715827: "" statement.0.sid: "PcfAdminIamPermissions" statement.1.actions.#: "24" statement.1.actions.1116652165: "ec2:AttachVolume" statement.1.actions.1666300009: "ec2:DescribeKeypairs" statement.1.actions.1765044567: "ec2:TerminateInstances" statement.1.actions.1802654865: "ec2:DescribeAccountAttributes" statement.1.actions.1874503478: "ec2:RunInstances" statement.1.actions.2254860184: "ec2:DeleteVolume" statement.1.actions.2270227066: "ec2:DescribeImages" statement.1.actions.235573035: "ec2:DescribeAddresses" statement.1.actions.2396526577: "ec2:CreateTags" statement.1.actions.2723879379: "ec2:DescribeVolumes" statement.1.actions.2727619928: "ec2:DescribeSnapshots" statement.1.actions.2772249080: "ec2:DescribeVpcs" statement.1.actions.3357331461: "ec2:DetachVolume" statement.1.actions.3381669024: "ec2:DisassociateAddress" statement.1.actions.3466923763: "ec2:DescribeInstances" statement.1.actions.3699372668: "ec2:DescribeSubnets" statement.1.actions.3958039885: "ec2:DescribeRegions" statement.1.actions.4046713676: "ec2:CreateVolume" statement.1.actions.4122399225: "ec2:AssociateAddress" statement.1.actions.681815053: "ec2:DescribeAvailabilityZones" statement.1.actions.70881040: "ec2:DescribeSecurityGroups" statement.1.actions.736710420: "ec2:RebootInstances" statement.1.actions.775716708: "ec2:DeleteSnapshot" statement.1.actions.852612933: "ec2:CreateSnapshot" statement.1.effect: "Allow" statement.1.resources.#: "1" statement.1.resources.2679715827: "" statement.1.sid: "PcfAdminEc2Permissions" statement.2.actions.#: "3" statement.2.actions.2009174805: "elasticloadbalancing:DescribeLoadBalancers" statement.2.actions.2706807274: "elasticloadbalancing:DeregisterInstancesFromLoadBalancer" statement.2.actions.982461153: "elasticloadbalancing:RegisterInstancesWithLoadBalancer" statement.2.effect: "Allow" statement.2.resources.#: "1" statement.2.resources.2679715827: "" statement.2.sid: "PcfAdminElbPermissions" statement.3.actions.#: "1" statement.3.actions.1834123015: "s3:" statement.3.effect: "Allow" statement.3.resources.#: "2" statement.3.resources.2555329161: "arn:aws:s3:::pcf-nonprod-bosh/*" statement.3.resources.3078316221: "arn:aws:s3:::pcf-nonprod-bosh" statement.3.sid: "PcfAdminS3Permissions" statement.4.actions.#: "1" statement.4.actions.646648939: "iam:PassRole" statement.4.effect: "Allow" statement.4.resources.#: statement.4.sid: "AllowToCreateInstanceWithCurrentInstanceProfile" statement.5.actions.#: "1" statement.5.actions.2362041738: "iam:GetInstanceProfile" statement.5.effect: "Allow" statement.5.resources.#: statement.5.sid: "AllowToGetInfoAboutCurrentInstanceProfile"

Plan: 74 to add, 0 to change, 0 to destroy.



* Links to any other associated PRs or issues:
NA

* [x] I have viewed signed and have submitted the Contributor License Agreement

* [X] I have made this pull request to the `master` branch

* [x] I have run all the unit tests 
NA
pivotal-issuemaster commented 6 years ago

@gopisaba Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

cf-gitbot commented 6 years ago

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

pivotal-issuemaster commented 6 years ago

@gopisaba Thank you for signing the Contributor License Agreement!

abbyachau commented 6 years ago

Hi @gopisaba thanks for creating this pull request. Our pipelines deploy the c0 reference architecture by design, as described here and therefore we are careful to pull in requests which change our terraform scripts. However we will review your pr as a best effort attempt to see if any of the suggested changes should be incorporated. Since changing our terraform scripts is not high priority at the moment, it may take some time for us to review your pull request. Thank you again.

calebwashburn commented 6 years ago

Thanks for the PR we are looking to allow more flexibility if your architecture differs but still use the common tasks to deploy your environment.