search

vmware-archive / pcf-pipelines

PCF Pipelines
Apache License 2.0
158 stars 282 forks source link

Disable-errands task only disabled post-deploy errands #312

Open rmeharg opened 6 years ago

rmeharg commented 6 years ago

Thanks for submitting an issue to pcf-pipelines. To help us triage the issue, please fill out the following form as much as you can:

Issue

https://github.com/pivotal-cf/pcf-pipelines/blob/master/tasks/disable-errands/task.sh can't disable pre-delete errands (it can only disable post-deploy errands).

Context

Customer is not using on-demand services and would like to disable the pre-delete errands as well and the post-deploy errands.

An operator would like to delete a tile from Ops Manager without having to modify or change errand configuration.

Expected result

Task will enable/disable pre-delete errands

Current result

Task fails when pre-delete errands are included with message: could not execute "set-errand-state": post-deploy-state "true" is invalid

Steps to Reproduce

Run disable-errands task and include pre-delete errands

Possible Fix

Additional logic to use --pre-delete-state or a separate task for disable-pre-delete-errands

cf-gitbot commented 6 years ago

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

abbyachau commented 6 years ago

Hey @RMeharg thank you for raising this issue. Could you please talk through how you are deleting tiles using the pcf-pipelines? Currently our pcf-pipelines offering only allows for installation, and upgrade to patch releases. Is the pre-delete errands running when you run the upgrade-tile or the upgrade-ops-manager pipelines? Thanks.

rmeharg commented 6 years ago

Hi @abbyachau , we are deleting tiles using the wipe-env task for install-pcf after spinning up PCF with a bunch of tiles. We use the upgrade-tile pipeline to install all the associated tiles. This wipe-env task fails because on-demand services are not enabled on the installation and the on-demand pre-delete errands cannot be disabled.

We would like the option to delete individual tiles as well but I believe the Ops Manager API does not support this currently.