vmware-archive / pcf-pipelines

PCF Pipelines
Apache License 2.0
158 stars 282 forks source link

Azure file storage is not used when configured #349

Open gondoi opened 6 years ago

gondoi commented 6 years ago

Issue

When using install-pcf on Azure from the master branch, defining azure_storage_account_name as suggested in the params comments, does not actually configure the PAS tile to use Azure storage and defaults to internal (NFS). This is with both 2.1 and 2.2 that I have tested.

Context

Defining this gives the expectation that the storage accounts created will be configured and used. Although, NFS is created and used and if this storage option is used, blobstore migration will have to be performed in order to switch.

Expected result

Use the storage type defined.

Current result

The option is ignored and internal storage is used.

Steps to Reproduce

Define, run pipeline, and review settings in PAS for file storage.

cf-gitbot commented 6 years ago

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

gondoi commented 6 years ago

I found that internal storage is hard coded in the task, so providing a value in the params file does nothing:

https://github.com/pivotal-cf/pcf-pipelines/blob/master/tasks/config-ert/task.sh#L170-L173